Thanks Hans,
I can agree on your propostion Jacopo, notably about time and quality,
especially on framework where even a small change can have
large side effects.
Sometimes joint work can do marvel, like we did recently on
https://issues.apache.org/jira/browse/OFBIZ-4289 Jacopo, but yes it
requires time and respect.
It's actually 2 years now that I constraint myself to commit prioritarily fixes
over new features. It happens that some
contributions fix an issue but introduce others (like for JMS). It's of course
most annoying when at the framework level.
Note that some errors in the framework are not detected immediately because
they concern not often used features. Who to blame then,
the one who introduced the initial error without noticing it (not always easy),
or the one who fixed it later and introduced a new
one (also not noticing it )? We immediatele see that this question does not
make sense. We can't become fossilized because of fear.
So we need more efforts from everyone, when it's about fixing issues in
framework. Simply exchanging and answering questions would
help to synchronize the efforts.
In other words, I agree on your proposition Jacopo, but I also demand more
participation of other committers. All contributions are
not valuable, but there are too much valuable contributions waiting in Jira.
Some with questions desesperately waiting answers, and
I don't speak only about new features...
I had to say it, even if I doubt it will have much effect
Jacques
From: "Hans Bakker" <[email protected]>
I think in general, Jacques does an excellent job, however if you do a lot of
commits, yes sure you have more errors than if you
only do a few. If he would not be here, hardly anything gets committed from
contributors.
For very complicated (framework) contributions I agree however simple ones and
in the applications I do not agree.
Regards,
Hans
On 07/01/2012 03:37 PM, Jacopo Cappellato wrote:
Jacques,
since in the past you have committed a series of contributions from others that
were implemented in a questionable way and are
requiring a considerable effort to be fixed, I would like to ask you to change
your protocol for committing them to OFBiz: if you
are interested in committing something, then review and test it completely;
then ask committers to confirm that it is a good
contribution and if no answer is received then please hold on because it means
that no other committer was either interested or
had time to review it.
It is better to move slowly and focus on quality.
What do the other committers think about this?
Kind regards,
Jacopo
On Jul 1, 2012, at 9:22 AM, Jacques Le Roux wrote:
https://issues.apache.org/jira/browse/OFBIZ-4944
This seems a good idea to me (did not review details yet), if nobody is against
(no answer implies OK), I will commit
Jacques
