Hi Jacques,

could you please explain why we are using the "entity-default" dispatcher here? 
Why not using the "default" dispatcher? Is this by design or it was just picked 
an existing one?

Jacopo

PS: As a side note, using the hardcoded "entity-default" (or "default") name is 
a bad practice because there is no guarantee that all the setup will have a 
delegator named "default".

On Apr 11, 2011, at 9:54 AM, [email protected] wrote:

> Author: jleroux
> Date: Mon Apr 11 07:54:22 2011
> New Revision: 1090961
> 
> URL: http://svn.apache.org/viewvc?rev=1090961&view=rev
> Log:
> Fixes a bug in AbstractJmsListener.java. This was 1st reported by Calum 
> Miller on user ML 3 years ago http://markmail.org/message/hb2r7vbjvekxbris. 
> But as it seems this is no often use nobody noticed since but at least Anand 
> H I who used the same in http://markmail.org/message/yvvm5nepopc7y246. It 
> appeared when you tried to set a jms-service in serviceengine.xml
> 
> Modified:
>    
> ofbiz/trunk/framework/service/src/org/ofbiz/service/jms/AbstractJmsListener.java
> 
> Modified: 
> ofbiz/trunk/framework/service/src/org/ofbiz/service/jms/AbstractJmsListener.java
> URL: 
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/org/ofbiz/service/jms/AbstractJmsListener.java?rev=1090961&r1=1090960&r2=1090961&view=diff
> ==============================================================================
> --- 
> ofbiz/trunk/framework/service/src/org/ofbiz/service/jms/AbstractJmsListener.java
>  (original)
> +++ 
> ofbiz/trunk/framework/service/src/org/ofbiz/service/jms/AbstractJmsListener.java
>  Mon Apr 11 07:54:22 2011
> @@ -50,7 +50,7 @@ public abstract class AbstractJmsListene
>      * @param dispatcher
>      */
>     protected AbstractJmsListener(ServiceDispatcher serviceDispatcher) {
> -        this.dispatcher = 
> GenericDispatcher.getLocalDispatcher("JMSDispatcher", null, null, 
> this.getClass().getClassLoader(), serviceDispatcher);
> +        this.dispatcher = 
> GenericDispatcher.getLocalDispatcher("entity-default", null, null, 
> this.getClass().getClassLoader(), serviceDispatcher);
>     }
> 
>     /**
> 
> 

Reply via email to