As long as no one else has a problem with it, I agree that we should
eliminate the unused feature.
-Adrian
On 7/26/2012 5:25 PM, Jacopo Cappellato wrote:
On Jul 26, 2012, at 3:47 PM, Adrian Crum wrote:
I think this has something to do with each application being a separate web
application (in a J2EE sense), but I'm just guessing. There seems to be a
reason you would need some services local to (or restricted to) a web
application, but I don't know what the reason is.
This was actually an old feature that was available but never used in years,
and I have excluded it in my recent refactoring (to make the code less complex,
more efficient and thread safe); I guess that was part of an initial plan but
then OFBiz evolved in a more component-centric rather than webapp-centric
architecture and I doubt we will ever need that feature.
Jacopo
-Adrian
On 7/26/2012 1:32 PM, Jacopo Cappellato wrote:
On Jul 26, 2012, at 11:51 AM, Jacopo Cappellato wrote:
* but the main question is: considering the layout described above, what is the
purpose/goal of having several instances of LocalDispatcher with different
names? Shouldn't we simply create one instance per delegator?
As a side note, this change(after the recent refactoring) should be rather easy
to implement; in fact it will be a matter of changing the signature of the
LocalDispatcher dispatcher = ServiceContainer.getLocalDispatcher(String
dispatcherName, Delegator delegator);
into:
LocalDispatcher dispatcher = ServiceContainer.getLocalDispatcher(Delegator
delegator);
and we will no more have to add the dispatcher name to the web.xml file of all
the web applications, for example:
<context-param>
<param-name>localDispatcherName</param-name>
<param-value>webtools</param-value>
<description>A unique name used to identify/recognize the local dispatcher for
the Service Engine</description>
</context-param>
Kind regards,
Jacopo
