From: "Jacopo Cappellato" <[email protected]>
On Jul 27, 2012, at 7:14 AM, Jacques Le Roux wrote:

Also did you read this comment
https://cwiki.apache.org/confluence/display/OFBTECH/Service+Engine+Guide#ServiceEngineGuide-ServiceDispatcher
 ?

Thank you Jacques, the document is really interesting because it describes the 
early design and confirms my understandings after
the research/review/refactoring I recently did, which brought up the 
questions/proposals we are discussing now.
I would like to mention that my refactoring simplified greatly the 
implementation (that was a bit messed up, as it is rather
natural, after years of modifications) but it didn't change the concepts 
described there... it actually makes the code closer to
them because it is easier to read it. However, as part of the refactoring, I 
also got rid of a few old and never used features
that are still documented in the document; for example:

* "The DispatchContext [...] contains [...] a 'bag' of user defined attributes."

this feature is no more available.

In general there are other details about it that are no more accurate (not 
because of my refactoring); for example it is not true
that the DispatchContext holds a reference to a delegator

Will they not miss to anyone? What is supposed to replace them? Were they 
really useless?

Should we update the document to reflect the recent changes?

Sure that's is most needed IMO (should not even be questionned ;o)

Jacques


Kind regards,

Jacopo

Reply via email to