Hi Hans,

some of the files added in your commit (highlighted below) come from an 
external project; however you forgot to add a reference to them in the LICENSE 
file; could you please take care of this? we have to complete this task before 
we can issue an official release.

Thanks,

Jacopo

PS: In general, when in a commit we include code from other projects it would 
be nice to clearly mention the fact in the commit log.

On Dec 24, 2010, at 4:22 PM, [email protected] wrote:

> Author: hansbak
> Date: Fri Dec 24 15:22:49 2010
> New Revision: 1052521
> 
> URL: http://svn.apache.org/viewvc?rev=1052521&view=rev
> Log:
> the first version of a product image management system when you want to 
> upload and approve prand manupulate product images, see catalog -> image 
> management
> 
> Added:
...
>    ofbiz/trunk/applications/product/webapp/catalog/imagemanagement/js/
>    
> ofbiz/trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.css
>    
> ofbiz/trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.js
>    
> ofbiz/trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.min.js
>    
> ofbiz/trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Rotate.js
>    
> ofbiz/trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.form.js
>    
> ofbiz/trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.function.js
>    
> ofbiz/trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js

Reply via email to