On Dec 11, 2012, at 2:09 PM, Erwan de FERRIERES wrote:
> BTW, Jacopo, I have resolved all the issues you were having in the previous
> patch, and I'm waiting for your comments.
> Are there still some issues ?
I apologize for the late reply.
First of all a premise: I have already expressed my personal opinion about the
pros and cons of delivering this tool ootb; by the way I would like to see if
there is a rather large number of users in this community interested in this
feature and in contributing tests.
That said, I have reviewed the patch (again) and I still see issues:
* several files without a license header
* added dependencies from framework to applications (OfbizConnection.java)
* the method getAllFuncTestSuiteInfos() is implemented but never used
* there are new code snippets that are commented out (why commit them?)
* the name "functional tests" doesn't seem appropriate to me ("user interface
tests"?)
* the method name JunitSuiteWrapper.processResourceHandler(...) is misleading
* do we really need to commit all the changes in all the application components
that simply add the same test to authenticate a user over and over?
But the main concern I have is still that at the beginning of this email: that
we are adding a lot of code and jars (downloaded thru ivy) in order to support
ui tests done for a specific tool but then no one will really contribute
significant test suites based on it.
Jacopo
