Hi Jacques, I don't think we discussed this specifically, and I am actually not even sure this naming convention is the best approach we could adopt: all I know it works well for Tomcat (now upgrading Tomcat is rather simple while in the past it was a pain... but this is also a consequence of the switch I did some time ago to the "embedded" distribution, available in the new releases) and so I decided to use it while I was upgrading "Ant" (because its jar files were missing any release information) The new format is nice because from the first part of the jar name you can understand from which release file we got it, while the second part is the original name of the jar (as found in the release file). We can see how it works in the next months and see if we like it, before discussing and making it a rule; or if you want we can discuss it now and see if the community can come up with a solution. Another important reason I have adopted it for Ant is that there are other jar files for Ant that don't come from the Ant distribution (e.g. ant-contrib*, ant-nodeps*) and they currently have a different release number as suffix: now it is easier to distinguish between them and the jars in the core distribution (because the jars from the core distribution now have the prefix ant-1.9.0-)
I hope I was able to explain my reasonings adequately. Jacopo On Mar 27, 2013, at 10:55 PM, Jacques Le Roux <[email protected]> wrote: > Hi Jacopo, > > I'm not against this new way of naming jars (I'm even for it) but where did > we discuss this? > > Thanks > > Jacques > > From: <[email protected]> >> Author: jacopoc >> Date: Wed Mar 27 17:01:12 2013 >> New Revision: 1461709 >> >> URL: http://svn.apache.org/r1461709 >> Log: >> Upgrade from Ant 1.8.4 to Ant 1.9.0: in the process I have also switched the >> naming convention of jars to the new one we are adopting for example for >> Tomcat jars that is >> <NAME-OF-THE-EXTERNAL-PROJECT>-<RELEASE-NUMBER>-<ORIGINAL-NAME-OF-JAR-FILE>. >> For example, in in the release package apache-ant-1.9.0.zip we have the jar >> ant-launcher.jar, the name of the jar in OFBiz is: ant-1.9.0-ant-launcher.jar >> >> >> Added: >> ofbiz/trunk/framework/base/lib/ant-1.9.0-ant-junit.jar (with props) >> ofbiz/trunk/framework/base/lib/ant-1.9.0-ant-launcher.jar (with props) >> ofbiz/trunk/framework/base/lib/ant-1.9.0-ant.jar (with props) >> ofbiz/trunk/framework/base/lib/ant/ant-1.9.0-ant-apache-bsf.jar (with >> props) >> Removed: >> ofbiz/trunk/framework/base/lib/ant-1.8.4.jar >> ofbiz/trunk/framework/base/lib/ant-junit-1.8.4.jar >> ofbiz/trunk/framework/base/lib/ant-launcher-1.8.4.jar >> ofbiz/trunk/framework/base/lib/ant/ant-apache-bsf-1.8.4.jar >> Modified: >> ofbiz/trunk/.classpath >> ofbiz/trunk/LICENSE >> ofbiz/trunk/ant >> >> Modified: ofbiz/trunk/.classpath >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/.classpath?rev=1461709&r1=1461708&r2=1461709&view=diff >> ============================================================================== >> --- ofbiz/trunk/.classpath (original) >> +++ ofbiz/trunk/.classpath Wed Mar 27 17:01:12 2013 >> @@ -17,10 +17,10 @@ >> <classpathentry kind="lib" >> path="applications/content/lib/tika-parsers-1.0.jar"/> >> <classpathentry kind="lib" >> path="applications/product/lib/watermarker-0.0.4.jar"/> >> <classpathentry kind="lib" >> path="applications/product/lib/dozer-4.2.1.jar"/> >> - <classpathentry kind="lib" path="framework/base/lib/ant-1.8.4.jar"/> >> - <classpathentry kind="lib" >> path="framework/base/lib/ant-junit-1.8.4.jar"/> >> - <classpathentry kind="lib" >> path="framework/base/lib/ant-launcher-1.8.4.jar"/> >> - <classpathentry kind="lib" >> path="framework/base/lib/ant/ant-apache-bsf-1.8.4.jar"/> >> + <classpathentry kind="lib" path="framework/base/lib/ant-1.9.0-ant.jar"/> >> + <classpathentry kind="lib" >> path="framework/base/lib/ant-1.9.0-ant-junit.jar"/> >> + <classpathentry kind="lib" >> path="framework/base/lib/ant-1.9.0-ant-launcher.jar"/> >> + <classpathentry kind="lib" >> path="framework/base/lib/ant/ant-1.9.0-ant-apache-bsf.jar"/> >> <classpathentry kind="lib" >> path="framework/base/lib/ant/ant-nodeps-1.8.1.jar"/> >> <classpathentry kind="lib" >> path="framework/base/lib/antisamy-bin.1.2.jar"/> >> <classpathentry kind="lib" >> path="framework/base/lib/avalon-framework-4.2.0.jar"/> >> >> Modified: ofbiz/trunk/LICENSE >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/LICENSE?rev=1461709&r1=1461708&r2=1461709&view=diff >> ============================================================================== >> --- ofbiz/trunk/LICENSE (original) >> +++ ofbiz/trunk/LICENSE Wed Mar 27 17:01:12 2013 >> @@ -10,10 +10,10 @@ OFBiz and the full text of the license u >> For additional details, see the NOTICE file. >> ========================================================================= >> The following libraries are licensed under the Apache License Version 2.0: >> -ofbiz/trunk/framework/base/lib/ant-launcher-1.8.4.jar >> -ofbiz/trunk/framework/base/lib/ant-1.8.4.jar >> -ofbiz/trunk/framework/base/lib/ant-junit-1.8.4.jar >> -ofbiz/trunk/framework/base/lib/ant/ant-apache-bsf-1.8.4.jar >> +ofbiz/trunk/framework/base/lib/ant-1.9.0-ant-launcher.jar >> +ofbiz/trunk/framework/base/lib/ant-1.9.0-ant.jar >> +ofbiz/trunk/framework/base/lib/ant-1.9.0-ant-junit.jar >> +ofbiz/trunk/framework/base/lib/ant/ant-1.9.0-ant-apache-bsf.jar >> ofbiz/trunk/framework/base/lib/ant/ant-nodeps-1.8.1.jar >> ofbiz/trunk/framework/base/lib/avalon-framework-4.2.0.jar >> ofbiz/trunk/framework/base/lib/avalon-util-exception-1.0.0.jar >> >> Modified: ofbiz/trunk/ant >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/ant?rev=1461709&r1=1461708&r2=1461709&view=diff >> ============================================================================== >> --- ofbiz/trunk/ant (original) >> +++ ofbiz/trunk/ant Wed Mar 27 17:01:12 2013 >> @@ -27,7 +27,7 @@ fi >> >> top="$(cd "$(dirname "$0")"; echo "$PWD")" >> find_jar() { >> - set -- "$top"/framework/base/lib/ant-launcher-*.jar >> + set -- "$top"/framework/base/lib/*ant-launcher.jar >> if [ $# = 1 ] && [ -e "$1" ]; then >> echo "$1" >> else >> >> Added: ofbiz/trunk/framework/base/lib/ant-1.9.0-ant-junit.jar >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/lib/ant-1.9.0-ant-junit.jar?rev=1461709&view=auto >> ============================================================================== >> Binary file - no diff available. >> >> Propchange: ofbiz/trunk/framework/base/lib/ant-1.9.0-ant-junit.jar >> ------------------------------------------------------------------------------ >> svn:mime-type = application/octet-stream >> >> Added: ofbiz/trunk/framework/base/lib/ant-1.9.0-ant-launcher.jar >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/lib/ant-1.9.0-ant-launcher.jar?rev=1461709&view=auto >> ============================================================================== >> Binary file - no diff available. >> >> Propchange: ofbiz/trunk/framework/base/lib/ant-1.9.0-ant-launcher.jar >> ------------------------------------------------------------------------------ >> svn:mime-type = application/octet-stream >> >> Added: ofbiz/trunk/framework/base/lib/ant-1.9.0-ant.jar >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/lib/ant-1.9.0-ant.jar?rev=1461709&view=auto >> ============================================================================== >> Binary file - no diff available. >> >> Propchange: ofbiz/trunk/framework/base/lib/ant-1.9.0-ant.jar >> ------------------------------------------------------------------------------ >> svn:mime-type = application/octet-stream >> >> Added: ofbiz/trunk/framework/base/lib/ant/ant-1.9.0-ant-apache-bsf.jar >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/lib/ant/ant-1.9.0-ant-apache-bsf.jar?rev=1461709&view=auto >> ============================================================================== >> Binary file - no diff available. >> >> Propchange: ofbiz/trunk/framework/base/lib/ant/ant-1.9.0-ant-apache-bsf.jar >> ------------------------------------------------------------------------------ >> svn:mime-type = application/octet-stream >> >>
