Re: svn commit: r1533839 - in /ofbiz/trunk: ./ framework/base/src/org/ofbiz/base/container/ framework/catalina/src/org/ofbiz/catalina/container/ framework/common/servicedef/ framework/service/config/ framework/service/src/org/ofbiz/service/config/model/ fr...

[Jacopo Cappellato]

With this change you have broken the thread safety of the ServiceLocation.java 
class; where you aware of this?

Jacopo

On Oct 20, 2013, at 12:07 AM, jler...@apache.org wrote:

> Modified: 
> ofbiz/trunk/framework/service/src/org/ofbiz/service/config/model/ServiceLocation.java
> URL: 
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/org/ofbiz/service/config/model/ServiceLocation.java?rev=1533839&r1=1533838&r2=1533839&view=diff
> ==============================================================================
> --- 
> ofbiz/trunk/framework/service/src/org/ofbiz/service/config/model/ServiceLocation.java
>  (original)
> +++ 
> ofbiz/trunk/framework/service/src/org/ofbiz/service/config/model/ServiceLocation.java
>  Sat Oct 19 22:07:35 2013
> @@ -28,7 +28,7 @@ import org.w3c.dom.Element;
> @ThreadSafe
> public final class ServiceLocation {
> 
> -    private final String location;
> +    private String location;
>     private final String name;
> 
>     ServiceLocation(Element serviceLocationElement) throws 
> ServiceConfigException {
> @@ -48,6 +48,10 @@ public final class ServiceLocation {
>         return location;
>     }
> 
> +    public void setLocation(String location) {
> +        this.location = location;
> +    }
> +
>     public String getName() {
>         return name;
>     }