[
https://issues.apache.org/jira/browse/OFBIZ-5294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213588#comment-14213588
]
Mridul Pathak commented on OFBIZ-5294:
--------------------------------------
It doesn't sounds like a bug. It could be categorized as a code level
improvement but it is doubtful that is needed at all. This is a common coding
pattern in OFBiz followed not only in product component but various other
components. You do have ability to define generic screen decorators in
CommonScreens.xml, but at the same time I believe that it is acceptable to
define decorators specific to a set of screens in a separate file containing
those screens. Here are some OOTB references for similar coding pattern,
# Accounting
#* AgreementScreens.xml
#* Billing AccountScreens.xml
#* FinAccountScreens.xml
#* etc.
# Order
#* OrderHeaderScreens.xml
#* OrderReturnScreens.xml
#* etc.
# Party
# Marketing
# etc.
We could keep this issue open for more inputs around best practices for these
coding patterns. Unless we receive any more comments, we could probably resolve
this issue.
> Common screen decorators don't follow best practice of being in
> CommonScreens.xml
> ---------------------------------------------------------------------------------
>
> Key: OFBIZ-5294
> URL: https://issues.apache.org/jira/browse/OFBIZ-5294
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 11.04, Release Branch 12.04, Release
> Branch 13.07, Trunk
> Reporter: Pierre Smits
>
> Commonly screen decorators are found in file CommonScreens.xml of the
> component. However, this is not the case for various screens in the Product
> component.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
