[
https://issues.apache.org/jira/browse/OFBIZ-5294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214105#comment-14214105
]
Jacques Le Roux commented on OFBIZ-5294:
----------------------------------------
Like Pierre, my 1st feeling, is to have all decorators in the
CommonScreens.xml. Like for instance we have CommonPaymentDecorator in
accounting CommonScreens.xml. This because it's easier to find a decorator when
you know all are in the same place.
On the other hand, it's sometimes easier to have all specific decorators at
hand in the same file. And, as says Mridul, it's a common practice in OFBiz.
This is also something David enforced in Moqui. I tend to agree, by experience,
having to navigate between several files can sometimes be a pain (a real one,
think wrists and shoulders ;) )
So, thought I'm a bit undecided, I believe we should close this issue as "not a
problem". Of course we could vote, this would be fun, with maybe better ideas
than mine :)
> Common screen decorators don't follow best practice of being in
> CommonScreens.xml
> ---------------------------------------------------------------------------------
>
> Key: OFBIZ-5294
> URL: https://issues.apache.org/jira/browse/OFBIZ-5294
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 11.04, Release Branch 12.04, Release
> Branch 13.07, Trunk
> Reporter: Pierre Smits
>
> Commonly screen decorators are found in file CommonScreens.xml of the
> component. However, this is not the case for various screens in the Product
> component.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
