[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300267#comment-15300267
]
Jacques Le Roux commented on OFBIZ-6783:
----------------------------------------
Also note that my commit r1745451 has an impact, before I got these kind of
error (w/ or w/o your changes) when running the "test" or "--test" options with
suite or test names:
{code}
Exception in thread "Thread-45" java.lang.RuntimeException:
org.ofbiz.minilang.MiniLangException: Could not find SimpleMethod testIfRegexp
in XML document in resource: component://minilang/script/org/ofbiz/mi
nilang/method/ifops/IfRegexpTests.xml
at
org.ofbiz.minilang.method.ifops.test.IfRegexpTest$MyThread.run(IfRegexpTest.java:82)
Caused by: org.ofbiz.minilang.MiniLangException: Could not find SimpleMethod
testIfRegexp in XML document in resource:
component://minilang/script/org/ofbiz/minilang/method/ifops/IfRegexpTests.xml
at
org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:272)
at
org.ofbiz.minilang.method.ifops.test.IfRegexpTest$MyThread.run(IfRegexpTest.java:74)
{code}
This was maybe Windows only, which did not help. Anyway it's done now!
> Refactor the start component
> ----------------------------
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Upcoming Branch
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java, error.log,
> ofbiz.log
>
>
> Looking at the main method and design of Start.java and the start component
> overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at
> Start! Given that this is an important component, I will provide a patch to
> be reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
