[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307283#comment-15307283
]
Taher Alkhateeb commented on OFBIZ-6783:
----------------------------------------
Hi Jacopo,
The patch you provided breaks in eclipse. I think the reason is that you
removed the entire line when you should just remove the "excluding" clause
In other words, you change from:
{code:xml}
<classpathentry excluding="org/ofbiz/base/config/CoberturaInstrumenter.java"
kind="src" path="framework/base/src"/>
{code}
to
{code:xml}
<classpathentry kind="src" path="framework/base/src"/>
{code}
> Refactor the start component
> ----------------------------
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Upcoming Branch
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783-hiddenfiles.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, StartCommandUtil.java, error.log, ofbiz.log
>
>
> Looking at the main method and design of Start.java and the start component
> overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at
> Start! Given that this is an important component, I will provide a patch to
> be reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
