Hey Folks, I would prefer to keep dead code away from the top level OFBiz directory. If you keep it there then you make it _closer_ to the framework!
Anyway, I don't see a problem with keeping it in specialpurpose! You are not creating a component, you are just creating a folder called reference and adding stuff to it, and you are not adding it to component-load.xml? Why is it that you cannot add it there? Regards, Taher Alkhateeb On Thu, Jun 16, 2016 at 3:55 PM, Mridul Pathak < [email protected]> wrote: > Introducing new directory “reference” seems reasonable approach to me as > it is a combined solution to everyone’s views. > > -- > Thanks & Regards, > Mridul Pathak > Senior Manager > HotWax Systems > http://www.hotwaxsystems.com > > > On Jun 16, 2016, at 5:56 PM, Jacques Le Roux < > [email protected]> wrote: > > > > Hi Divesh, > > > > Le 16/06/2016 à 13:38, Divesh Dutta a écrit : > >>> 3- In the case of non-compiling / broken / missing dependencies code > >>>> >>highlight this issue somewhere visible to the programmer (README, > >>>> >>whatever). Why is this important? Because we need to tell our build > >>>> >>scripts > >>>> >>and our classpath settings to ignore these files. > >>>> >> > >>>> >>The reason why I suggested to keep all of them in > >>>> >>/reference/each-component-name-here is to tell the build system to > ignore > >>>> >>all Java files found in /specialpurpose/reference. If you instead > break it > >>>> >>up into multiple components, then I need to ignore the files in each > >>>> >>component by hand which makes the build script more complex and > more prone > >>>> >>to human error and it would add to the confusion. > >>>> >> > >>> >I agree and I think your initial proposition ("How about > >>> >reference/paymentext and reference/whatever-else-you-want?") was not > >>> >clearly understood by Pierre and maybe not Divesh. Pierre, Divesh? > >>> > > >> Actually Jacques, we cannot create component like > >> specialpurpose/reference/paymentext . Other way can be we introduce new > >> directory "reference" in parallel to specialpurpose, applications , > >> framework . Do you mean to do that ? > > > > You are right, and following Taher's idea I missed this point, it seems > to me that your proposition of <<introducing a new directory "reference" in > parallel to specialpurpose, applications ,framework>> is the best one so > far. > > It could be also that Taher anticipated on the work (I know) he will do > on refactoring the build system and this possibility will be open "soon", > Taher? > > > >> > >> Also as Mridul put it, and you agreed, the "shipping integration/s" > which > >>> >"doesn’t have the compilation or library reference issues" would be > in its > >>> >own independent component/s (ie not under /reference), same for other > stuff > >>> >with the same status, if exist. > >> In this case, shipping integration can be under special purpose. So > >> specialpurpose/shippingIntegratio. > > > > Clearly, nobrainer :) > > > > Jacques > >> > >> > >> Thanks > >> -- > >> Divesh Dutta. > >> > >> > >> > > > >
