Hi Taher, OFBTOOLS is not required as it is already defined in the template to be included. When added in basePermission it leads to duplication in the generated ofbiz-component.xml file.
I already created an issue for that, see https://issues.apache.org/jira/browse/OFBIZ-7785 Best regards, Pierre Smits ORRTIZ.COM <http://www.orrtiz.com> OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Tue, Jul 19, 2016 at 11:04 AM, Taher Alkhateeb < [email protected]> wrote: > Hi Pierre, > > Hmmm, that's actually a nice idea. I suggest however we avoid componentId > and just apply the following to the variables: > > componentName: mandatory > componentResourceName: optional, defaults to componentName > webappName: optional, defaults to componentName > basePermission: optional, defaults to OFBTOOLS (or whatever defaults were) > > This way, You get a real nice and simple command for end-users to create > new components while at the same time allowing more expressiveness. This > becomes similar to the createTenant task which also has everything optional > except the tenantId and tenantName > > Taher Alkhateeb > > On Tue, Jul 19, 2016 at 11:58 AM, Pierre Smits <[email protected]> > wrote: > > > Hi all, > > > > Currently our create component process (./gradlew createComponent) is > error > > prone. > > > > It requires 4 variables to successfully create a new component in the > > hot-deploy folder to jumpstart development with a component skeleton. > These > > variables are: > > > > - componentName > > - componentResourceName > > - webappName > > - basePermission > > > > I believe we should reduce the number of variables to just 1 variable > (e.g. > > componentId) to create consistency throughout the skeleton and its > > associated datasets. The developer can, after a skeleton has been built, > > then apply any kind of changes according to his/her requirements an > needs. > > > > What is your opinion on this? > > > > Best regards, > > > > Pierre Smits > > > > ORRTIZ.COM <http://www.orrtiz.com> > > OFBiz based solutions & services > > > > OFBiz Extensions Marketplace > > http://oem.ofbizci.net/oci-2/ > > >
