Hi Taher, all Re: --both and --pos I agree that logic regarding the pos component should reside in the component. But, since I don't know what the reasons behind these commands are, I suggest we should defer the decision until Jacques (who I believe build the construct) has explained a bit about background.
Re --testlist Maybe it is useless. I don't know. But someone probably had a good reason to implement it. The revision history might give a clue regarding whom to ask. As for 'to my knowledge no one is using it': if you want to find out who is, you should ask in the user ml if there is someone and defer a short period (e.g. the min 72hr) to allow anybody to come forward. Best regards, Pierre Smits ORRTIZ.COM <http://www.orrtiz.com> OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Thu, Jul 21, 2016 at 11:38 AM, Taher Alkhateeb < [email protected]> wrote: > Hello Everyone, > > This is a proposal to _remove_ the following commands from the OFBiz server > (invoked with ./gradlew "ofbiz --commandHere" > > 1- --both > 2- --pos > 3- --testlist > > Reasons: > - The POS component is a specialpurpose component and should not have code > existing in the start component. Instead logic for starting the POS > component should reside inside the POS component and away from framework > - After lots of investigation I realized the testlist OFBiz command is a > weird command that used to create an ant file that just iterates over the > existing integration test suites and run them one by one, which is slower > vs just running them all. It is deprecated and to my knowledge no one is > using it. I think it used to serve some deprecated cobertura tasks. > > This would imply deleting the following files: > - > > framework/start/src/main/java/org/apache/ofbiz/base/start/testlist.properties > - > > framework/testtools/src/main/java/org/apache/ofbiz/testtools/TestListContainer.java > - > framework/base/src/main/java/org/apache/ofbiz/base/splash/SplashLoader.java > > and modifying the following files: > - framework/start/src/main/java/org/apache/ofbiz/base/start/Config.java > - > > framework/start/src/main/java/org/apache/ofbiz/base/start/StartupCommandUtil.java > - (move it to POS) > framework/base/src/main/java/org/apache/ofbiz/base/splash/SplashScreen.java > > Agreed? > > Regards, >
