Jacopo, That my feedback may be regarded as a distraction (to someone) is something else. That Taher suggests 'not to block such...' is an accusation, as I perceive it.
As for the --testlist I see a (potential) added value for the testers working for our adopters, especially in the environment of CI. Hence my suggestion to ask in the greater OFBiz community (the user ml) first before taking the next step, than to change stuff based on limited knowledge. Best regards, Pierre Smits ORRTIZ.COM <http://www.orrtiz.com> OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Thu, Jul 21, 2016 at 2:11 PM, Jacopo Cappellato < [email protected]> wrote: > +1 to the proposal and I am interested to see what (if) others have to say. > > Jacopo > > On Thu, Jul 21, 2016 at 11:38 AM, Taher Alkhateeb < > [email protected]> wrote: > > > Hello Everyone, > > > > This is a proposal to _remove_ the following commands from the OFBiz > server > > (invoked with ./gradlew "ofbiz --commandHere" > > > > 1- --both > > 2- --pos > > 3- --testlist > > > > Reasons: > > - The POS component is a specialpurpose component and should not have > code > > existing in the start component. Instead logic for starting the POS > > component should reside inside the POS component and away from framework > > - After lots of investigation I realized the testlist OFBiz command is a > > weird command that used to create an ant file that just iterates over the > > existing integration test suites and run them one by one, which is slower > > vs just running them all. It is deprecated and to my knowledge no one is > > using it. I think it used to serve some deprecated cobertura tasks. > > > > This would imply deleting the following files: > > - > > > > > framework/start/src/main/java/org/apache/ofbiz/base/start/testlist.properties > > - > > > > > framework/testtools/src/main/java/org/apache/ofbiz/testtools/TestListContainer.java > > - > > > framework/base/src/main/java/org/apache/ofbiz/base/splash/SplashLoader.java > > > > and modifying the following files: > > - framework/start/src/main/java/org/apache/ofbiz/base/start/Config.java > > - > > > > > framework/start/src/main/java/org/apache/ofbiz/base/start/StartupCommandUtil.java > > - (move it to POS) > > > framework/base/src/main/java/org/apache/ofbiz/base/splash/SplashScreen.java > > > > Agreed? > > > > Regards, > > >
