Sorry, I started this thread by asking this question:
>While committing r1760406 I wondered if I should really put semicolons at end
of Groovy files lines.
>We know it's useless in Groovy. Should we continue to put them, and if yes for
which reasons?
The question switched to "should we remove all the trailing semicolons from all the
Groovy files"
We all know it's an easy task using a S/R regexp to remove all the trailing semicolons from all the Groovy files in one shoot. Or maybe for easier
reviews in several shoots (by component? But who will really review these changes?)
So I don't feel we have answered my question but we rather sidetracked to a solution I did not ask about. This because of the possible end of lines
inconsistency in Groovy files.
Before applying a such change, I'd really like to know if everybody is aware of what that means when it comes to svn annotations. I repeat: we will
then lose all the svn annotations history in all the Groovy files.
And that seems to me to be more a concern than consistency in Groovy files!
To get the idea: unrelated but close, we decided to move files around in OFBiz, OK. But now backporting bug fixes is a pain. You have to change files
paths by hand. This is the kind of changes that must thought thorough before taking a decision.
Thanks
Jacques
Le 13/09/2016 à 16:17, Michael Brohl a écrit :
Thanks, Rishi!
Am 13.09.16 um 15:10 schrieb Rishi Solanki:
+1 Taher, until we will have complete switch to pure groovy we should keep
the semicolon as practice.
+1 Michael, for migrating to pure Groovy.
We would try to assign dev for it and log Jira ticket accordingly.
Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
