I agree with Jacopo, these are very functional changes that shouldn't be made without understanding the workflow. It's good to clean up the code but it shouldn't be done blindly.
On 25 March 2017 at 02:13, Jacopo Cappellato < [email protected]> wrote: > On Fri, Mar 24, 2017 at 10:56 AM, Jacques Le Roux < > [email protected]> wrote: > > > [...] > > If we (both and All) agree on collaborating to document on purpose > > swallowed exceptions, even when you are not directly concerned, then I > > agree to revert my changes, deal? > > > We are not negotiating: I have simply asked you to revert the changes in > which you have changed the functional behavior of the system without > testing OR test the new behavior and confirm it is working fine. > > In general I like the effort of improving this old code containing > swallowed exceptions by providing more comments, documentation etc... or > completely refactoring it; but this has to be done with proper testing. > > I hope this clarifies my request. > > Jacopo >
