On Mon, Mar 27, 2017 at 10:24 AM, Michael Brohl <[email protected]> wrote:
> Hi Jacopo, > > I'm not for a general change to Review-Then-Commit but pleading for a more > sensible way to handle these things as a responsible committer. > > As a guideline: if in doubt, always provide a patch and describe what the > change should do or fix and let others review. > > Of course not for trivial changes or fixes. But when it comes to new > modules, significantly changing the behaviour of the business logic etc. I > think it's better to apply Review-Then-Commit. > > And of course, if others want a commit to be reverted, we should do it > first and then discuss. > > Regards, > > Michael > I totally agree with all you wrote Michael. Jacopo
