[
https://issues.apache.org/jira/browse/OLINGO-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353148#comment-14353148
]
Christian Amend commented on OLINGO-567:
----------------------------------------
Hi Kevin,
thank you for the patch. As we have done a lot of refactoring in the last few
days I was not able to apply it to the current master. Could you please give me
the commit id which you based this patch on? Or could you rebase your local
repository against the current master and create a new patch file?
Although I could not apply the patch I had a look at it. I like it very much
that you are reusing existing code. This helps further development. I also like
the sample you provided this makes manual testing with a rest client very easy.
What I have been missing a bit are automated tests using the JUnit framework.
We try to provide a Unit test for every feature we implement. This helps a lot
to ensure that no functionality gets broken by introducing a new functionality
or bugfix. You can have a look at our server-test module. There you could place
such tests or find guidance on how to implement them.
Finally the last thing I saw was that you introduced a getEntityDataModel()
method at the EdmEntityType. What was the reason for that? in my opinion an
EntityType does not need to know the EDM he is from so if you need EDM access
in the serializer it should be something you give the serializer as a
parameter. What do you think about that?
Thank you again for your great work and Best Regards,
Christian
> Support odata.metadata=full on server side serialization
> --------------------------------------------------------
>
> Key: OLINGO-567
> URL: https://issues.apache.org/jira/browse/OLINGO-567
> Project: Olingo
> Issue Type: Improvement
> Components: odata4-server
> Affects Versions: (Java) V4 4.0.0-beta-02
> Reporter: Christian Amend
> Assignee: Christian Amend
> Fix For: (Java) V4 4.0.0-beta-03
>
> Attachments:
> odata_metadata=full_support_for_V4_4_0_0-beta-02-Version2.patch,
> odata_metadata=full_support_for_V4_4_0_0-beta-02-Version2_examples.txt,
> odata_metadata=full_support_for_V4_4_0_0-beta-02.patch
>
>
> Support odata.metadata=full on server side serialization. Currently we throw
> a not supported exception during serializer creation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
