[
https://issues.apache.org/jira/browse/OLINGO-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353218#comment-14353218
]
Kevin Ratnasekera commented on OLINGO-567:
------------------------------------------
Hi Christian,
Thank you very much for your feedback.
I think it will be convienient for you if I rebase my local repository with
master and create a new patch. Please do give me some time.
I will add another JUnit test cases fo the conpensation of test currently gets
broken due to this changes. Yes sure I will look into the server-test module
that will give me some guidance to implement test cases.
Yes, I agree that introducing getEntityDataModel() to EdmEntityType make no
sense as he need not know the EDM. Primary objective of introducing such change
is basically to get access to the EDM. Using access to the EDM, I have the
access to the EdmEntitySet of a entity set so that it can be used build the
canonical URL - new UriHelperImpl().buildCanonicalURL(edmEntitySet, entity) so
that it can be used to create metadata of entity such as entity id.
In ODataJsonSerializer we have entity serialization methods for entity set,
public InputStream entityCollection(final EdmEntityType entityType, final
EntitySet entitySet,
final EntityCollectionSerializerOptions options) throws
SerializerException
so in here we are providing EdmEntityType, so we do not have direct access to
the EDM from the EdmEntityType. As you suggested we can provide EDM directly
here as for service document serialization,
public InputStream serviceDocument(final Edm edm, final String serviceRoot)
What do think?
I didnt want make much changes to the method signatures, as current argument
passing to this methods make more sense and it will make lot more interface
changes that will broken up the code. So is it ok if I change the first
argument to the entity Collection serialization methods, from EdmEntityType to
Edm?
Please do give me sometime to make these changes there are also formatting
issues in previous patches I will make according to the standard.
Regards
Kevin
> Support odata.metadata=full on server side serialization
> --------------------------------------------------------
>
> Key: OLINGO-567
> URL: https://issues.apache.org/jira/browse/OLINGO-567
> Project: Olingo
> Issue Type: Improvement
> Components: odata4-server
> Affects Versions: (Java) V4 4.0.0-beta-02
> Reporter: Christian Amend
> Assignee: Christian Amend
> Fix For: (Java) V4 4.0.0-beta-03
>
> Attachments:
> odata_metadata=full_support_for_V4_4_0_0-beta-02-Version2.patch,
> odata_metadata=full_support_for_V4_4_0_0-beta-02-Version2_examples.txt,
> odata_metadata=full_support_for_V4_4_0_0-beta-02.patch
>
>
> Support odata.metadata=full on server side serialization. Currently we throw
> a not supported exception during serializer creation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
