Hi,
Looks good to me and ready for the initial check in.
I'll help with the check in.
- Florian
On Jul 25, 2013, at 5:52 PM, Dave Fisher wrote:
Hi,
With my mentor hat on.
The project should check in the code as it is granted.
Then someone in the project who works for SAP should make the header
changes.
I see that the changes are all made and that the OLINGO-1 has the
provenance. Great!
The most important part of the first release for this podling is
make sure that the headers are correct. The ASF has a tool that helps
called Apache RAT. It can be found here: http://creadur.apache.org/
This will be a useful monitoring tool.
Regards,
Dave
Regards,
Dave
On Jul 23, 2013, at 9:14 AM, Florian Müller wrote:
Hi Stephan,
Before we check the code into the Apache Git, we should make a few
general changes to it.
We should have at least the Apache header in each source file. It
would
also be good to change package names to something like
"org.apache.olingo...".
Florian
I found the attach button, so code is available as ZIP here:
https://issues.apache.org/jira/browse/OLINGO-1
I have taken the latest version from GitHUB. The ZIP doesn't
contain the
history and it is not refactored yet. We can do this as community
task.
- Stephan
On 23.07.13 13:00, "Bolz, Michael" <[email protected]> wrote:
Hi,
First question for me, what should be included in the "Initial
commit"?
In my opinion we should check in the current code base without
the
complete 'git' history.
What do you think?
@Stephan:
You can attach files to your issue
(https://issues.apache.org/jira/browse/OLINGO-1 -> "More Actions
-> Attach
Files"), but only to a maximum of 10MB. Enough for the code, but
not for
the 'git' history.
Kind regards,
Michael
On 23.07.13 12:46, "Klevenz, Stephan" <[email protected]>
wrote:
@mentors
How does the initial code contribution works? I was thinking to
create a
Jira issue and attach the source code to it for documentation.
This seems
to be wrong because of attachments are not possible.
@all
Secondly some of us still struggle with ICLAs and do not have
Apache
users yet. Can someone else pick the code from
(https://github.com/SAP/cloud-odata-java) and do the initial
commit?
Regards,
Stephan
