Hi,
first time posting here :-)
Thanks for putting the code up in the repo.
I noticed a few things and wanted to bring them up.
I saw all pom files are currently using tabs instead of spaces. Will
you be fixing them?
And not directly related to the style, but indirectly when the
stylecheck gets activated by default and when you want to disable it
for a quick build, etc, could you add the fastinstall profile (to skip
some steps for a quick build)?
+ <profile>
+ <id>fastinstall</id>
+ <properties>
+ <maven.test.skip>true</maven.test.skip>
+ <!-- here we could also add checkstyle.skip = true
etc once the checkstyle gets activated by default -->
+ </properties>
+ </profile>
and the defaultGoal in build would be nice :-)
<build>
+ <defaultGoal>install</defaultGoal>
thanks.
regards, aki
p.s. by the way, I was testing the code against cxf-2.7.6. Everything
runs fine. So you can upgrade its cxf dependency to 2.7.6.
2013/8/13 Bolz, Michael <[email protected]>:
> Hi,
>
> Weekend is over and the result for line wrapping looks as follows:
> +6: "line wrapping policy"
> +1: "80 chars"
> +3: "120 chars"
> +2: "135 chars"
>
>
> So the winner is "line wrapping=true" with "120 chars".
>
> I adapted the checkstyle configuration and the usage in the parent pom
> (see commit "2849d4eba978b83155c6ac92cc46087134ff1ffe").
> Currently checkstyle has to be run manually (e.g. "mvn checkstyle:check")
> or over the quality build profile ("mvn package -Pbuild.quality").
>
> Next question is how we would "clean up" the code base?
> My suggestion would be to do one single "clean up run and git push"
> without further code changes.
> What do you think?
>
> Kind regards and a nice week
> Michael
>
