Hi Michael, thanks. Maybe you might want to just take the stylecheck setting and also pmd setting from other existing apache projects?
And I think it would be better to turn on these checks by default install and also be used during code editing in eclipse, no? That way, you won't postpone the fixing of the code or let others to fix. With the fastinstall option provided, you can always turn them off when you are in hurry and have a need for repeatedly mvn-building sub components to test another component, etc. regards, aki 2013/8/13 Bolz, Michael <[email protected]>: > Hi and Welcome Aki, > > > The Tabs in the pom will be fixed with the "initial code clean up run". > Which I think I will do till end of the week if nobody calls "veto". > > Our other points sounds interesting ("fast install") and should be > discussed. > The checkstyle plugin should only be executed within the "build.quality" > profile. > With other profiles it should be only executed if manually called (e.g. > via "mvn checkstyle:check") because of the "<execution>" configuration. > At least within my environment it works that way. Has anybody another > experience? > > > Nevertheless I think we can set the default goal to "install". > > Kind regards, > Michael > > PS: Thanks for the test with cxf-2.7.6 ;o) > > On 13.08.13 15:05, "Aki Yoshida" <[email protected]> wrote: > >>Hi, >>first time posting here :-) >>Thanks for putting the code up in the repo. >> >>I noticed a few things and wanted to bring them up. >> >>I saw all pom files are currently using tabs instead of spaces. Will >>you be fixing them? >> >>And not directly related to the style, but indirectly when the >>stylecheck gets activated by default and when you want to disable it >>for a quick build, etc, could you add the fastinstall profile (to skip >>some steps for a quick build)? >> >>+ <profile> >>+ <id>fastinstall</id> >>+ <properties> >>+ <maven.test.skip>true</maven.test.skip> >>+ <!-- here we could also add checkstyle.skip = true >>etc once the checkstyle gets activated by default --> >>+ </properties> >>+ </profile> >> >>and the defaultGoal in build would be nice :-) >> <build> >>+ <defaultGoal>install</defaultGoal> >> >>thanks. >>regards, aki >>p.s. by the way, I was testing the code against cxf-2.7.6. Everything >>runs fine. So you can upgrade its cxf dependency to 2.7.6. >
