[jira] [Commented] (OLINGO-30) Enhanced Media Resource Handling

[Christian Amend (JIRA)]

    [ 
https://issues.apache.org/jira/browse/OLINGO-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13792432#comment-13792432
 ] 

Christian Amend commented on OLINGO-30:
---------------------------------------

Hi Michael,

yes I saw that it was used during Json serialization but not for xml so I 
recommended the EntityWriteProperties. But since this is not compatible with 
previous versions I think it is a good idea to use the EdmMapping object 
instead. 

The only thing I don´t like is the naming. getMimeType does not delvier the 
mime type but a key which is used for the lookup in the data map similar to 
what I did with the WriteProperties. So I would suggest to set getMimeType to 
deprecated and use the two new methods instead: getMediaResourceSourceKey and 
getMediaResourceTypeKey

I would implement this and push it. WDYT?

> Enhanced Media Resource Handling
> --------------------------------
>
>                 Key: OLINGO-30
>                 URL: https://issues.apache.org/jira/browse/OLINGO-30
>             Project: Olingo
>          Issue Type: Improvement
>          Components: odata2-core
>    Affects Versions: 1.1.0
>            Reporter: Michael Bolz
>
> At the EntityProviderWriteProperties we have now two additional fields for a 
> mediaResourceSourceKey and mediaResourceTypeKey. If set we will look into the 
> data map with this key and use the String we find there as a source link for 
> this media resource during serialization.
> For example this: <content type="image/jpeg" src="Employees('1')/$value"/> 
> can now look like this <content type="image/jpeg" 
> src="http://localhost:8080/Image.jpeg"/> if the src key is set and the data 
> map is filled accordingly. The content type is filled the same way.
> JUnit tests can be found here:
> {{org.apache.olingo.odata2.core.ep.producer.AtomEntryProducerTest}}
>  -> serializeWithCustomSrcAttributeOnEmployee
>  -> serializeWithCustomSrcAndTypeAttributeOnEmployee
> {{org.apache.olingo.odata2.core.ep.producer. JsonEntryEntityProducerTest}} 
>  -> serializeWithCustomSrcAttributeOnEmployee
>  -> serializeWithCustomSrcAndTypeAttributeOnEmployee



--
This message was sent by Atlassian JIRA
(v6.1#6144)