Github user francisco-perez-sorrosal commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/3#discussion_r73977397
--- Diff:
tso-server/src/main/java/org/apache/omid/tso/ReplyProcessorImpl.java ---
@@ -67,7 +69,7 @@
private final Meter timestampMeter;
@Inject
- ReplyProcessorImpl(MetricsRegistry metrics, Panicker panicker,
ObjectPool<Batch> batchPool) {
+ ReplyProcessorImpl(TSOServerConfig config, MetricsRegistry metrics,
Panicker panicker, ObjectPool<Batch> batchPool) {
--- End diff --
Same comment as above. Inject strategy instead of tso config. Should be:
```java
@Inject
ReplyProcessorImpl(@Named("ReplyStrategy") WaitStrategy strategy,
MetricsRegistry metrics,
Panicker panicker,
ObjectPool<Batch> batchPool) {
//
------------------------------------------------------------------------------------------------------------
// Disruptor initialization
//
------------------------------------------------------------------------------------------------------------
ThreadFactoryBuilder threadFactory = new
ThreadFactoryBuilder().setNameFormat("reply-%d");
this.disruptorExec =
Executors.newSingleThreadExecutor(threadFactory.build());
this.disruptor = new Disruptor<>(EVENT_FACTORY, 1 << 12,
disruptorExec, MULTI, strategy);
...
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
