Github user francisco-perez-sorrosal commented on a diff in the pull request:

    https://github.com/apache/incubator-omid/pull/3#discussion_r73977412
  
    --- Diff: 
tso-server/src/main/java/org/apache/omid/tso/RetryProcessorImpl.java ---
    @@ -69,7 +72,8 @@
         private final Meter noCTFoundMeter;
     
         @Inject
    -    RetryProcessorImpl(MetricsRegistry metrics,
    +    RetryProcessorImpl(TSOServerConfig config,
    +                       MetricsRegistry metrics,
    --- End diff --
    
    Same comment as above. Inject strategy instead of tso config:
    
    ```java
        @Inject
        RetryProcessorImpl(@Named("RetryStrategy") WaitStrategy strategy,
                           MetricsRegistry metrics,
                           CommitTable commitTable,
                           ReplyProcessor replyProc,
                           Panicker panicker,
                           ObjectPool<Batch> batchPool)
                throws InterruptedException, ExecutionException, IOException {
    
            // 
------------------------------------------------------------------------------------------------------------
            // Disruptor initialization
            // 
------------------------------------------------------------------------------------------------------------
    
            ThreadFactory threadFactory = new 
ThreadFactoryBuilder().setNameFormat("retry-%d").build();
            this.disruptorExec = 
Executors.newSingleThreadExecutor(threadFactory);
    
            this.disruptor = new Disruptor<>(EVENT_FACTORY, 1 << 12, 
disruptorExec, SINGLE, strategy);
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to