Hi Simone
Thx for the good words.
1)
I removed the declared RuntimeExceptions in UnitOfWork and
PersistenceService.
But I left them in the JavaDoc.
2)
I deleted my m2 repository to get an absolute clean environment and did
a "mvn clean install".
All tests pass.
Here my setup:
Apache Maven 3.0.4 (r1232337; 2012-01-17 09:44:56+0100)
Maven home: /opt/maven/3.0.4
Java version: 1.6.0_45, vendor: Sun Microsystems Inc.
Java home: /opt/jdk/64/1.6.0_45/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.13.0-24-generic", arch: "amd64", family:
"unix"
I will try to get a hold of a mac. For Java 1.6 Apple provides their own
compiler and JVM...
Cheers
Stephan
On 05/19/2014 02:11 PM, Simone Tripodi wrote:
Hi again Stephan,
I had an overview on what you did and just have one single word: WOW!
Congrats and thanks a lot for taking care of such HUGE amount of code,
it is *impressive*!
Before to move outside the sandbox I think we need to quickly discuss
two small things:]
* both PersistenceService#start() and UnitOfWork#begin() throw
IllegalStateException: IMHO there's no need to add such exception in
methods signature, being an unchecked exception, but I'd leave in the
comment the advertisement for consumers that implementations may throw
runtime errors;
* when running `mvn clean install` I got few errors:
Tests in error:
EntityManagerFactoryFactoryTest.shouldCreateAnInstanceWithThePassedValues:63
? NoClassDefFound
NestedTransactionTest.testNestedTransactions:357->doTestNestedTransaction:376
? NoClassDefFound
SingleTransactionTest.setUp:61 ? NoClassDefFound Could not
initialize class or...
SingleTransactionTest.setUp:61 ? NoClassDefFound Could not
initialize class or...
SingleTransactionTest.setUp:61 ? NoClassDefFound Could not
initialize class or...
SingleTransactionTest.setUp:61 ? NoClassDefFound Could not
initialize class or...
SingleTransactionTest.setUp:61 ? NoClassDefFound Could not
initialize class or...
SingleTransactionTest.setUp:61 ? NoClassDefFound Could not
initialize class or...
SingleTransactionTest.setUp:61 ? NoClassDefFound Could not
initialize class or...
SingleTransactionTest.setUp:61 ? NoClassDefFound Could not
initialize class or...
SingleTransactionTest.setUp:61 ? NoClassDefFound Could not
initialize class or...
SingleTransactionTest.setUp:61 ? NoClassDefFound Could not
initialize class or...
SingleTransactionTest.setUp:61 ? NoClassDefFound Could not
initialize class or...
SingleTransactionTest.setUp:61 ? NoClassDefFound Could not
initialize class or...
This is the environment where I ran tests:
Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da;
2013-02-19 14:51:28+0100)
Maven home: /Applications/apache-maven-3.0.5
Java version: 1.6.0_65, vendor: Apple Inc.
Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
Default locale: en_US, platform encoding: MacRoman
OS name: "mac os x", version: "10.8.5", arch: "x86_64", family: "mac"
Once clarified these two points, I think we can go outside the sandbox :)
Thanks once again for the extraordinary effort on persist!!!
Alles Gute!
-Simo
http://people.apache.org/~simonetripodi/
http://twitter.com/simonetripodi
On Mon, May 19, 2014 at 9:00 AM, Stephan Classen <st.clas...@gmx.ch> wrote:
Please, take your time.
I invested about every minute of my spear time since Christmas into this
code.
What would you suggest would be an adequate amount of time?
Cheers
Stephan
On 05/18/2014 04:03 PM, Eric Charles wrote:
I would rather leave the vote open for more days to give more change for
reviews.
Thx, Eric
On 05/17/2014 08:39 PM, Stephan Classen wrote:
With only one vote in favor the voting has failled and onami persist will
stay in sandbox.
I would appreciate any hint on how to improve onami persist.
Cheers
Stephan
Am 13.05.2014 22:20 schrieb Stephan Classen <st.clas...@gmx.ch>:
Hi all devs.
Apache Onami persist has come great ways.
- Code is clean
- Unit test coverage is high
- Integration test coverage still needs some improvement
- Documentation is plentiful
So I feel it is time to release it into the wild.
Vote will be open for at least 72h and closes ~ May the 16th, at 8:00pm
GMT.
Many thanks in advance for reviewing
Stephan
