Great! Already documented and deployed in the sandbox, that's a prime. I love the EntityManagerProvider which prevents thread-safety issues on the EntityManager.
Thx, Eric On 05/23/2014 09:55 PM, Simone Tripodi wrote: > Salut Eric, > > Stephan added a dedicated chapter on persist site[1] to describe the > difference - he did an amazing job indeed! :) > > HTH, all the best! > -Simo > > [1] http://onami.apache.org/persist/guicePersist.html > http://people.apache.org/~simonetripodi/ > http://twitter.com/simonetripodi > > > On Fri, May 23, 2014 at 6:21 PM, Eric Charles <e...@apache.org> wrote: >> My vote: +1 to graduate >> >> I have built/tested, and reviewed from a copter the code. >> Awesome, you have done a great work - seems like you even support JTA, >> correct? >> >> Even you don't get huge feedback, be proud of it, and I am sure many >> people have seen your work. >> >> btw, how would you compare onami-persist to guice-persist? >> http://code.google.com/p/google-guice/wiki/GuicePersist >> >> Thx, Eric >> >> On 05/23/2014 07:08 AM, Stephan Classen wrote: >>> Hi Devs >>> >>> If there is not veto until Monday 12am GMT I will go ahead and move >>> onami-persist to trunk. >>> >>> Cheers >>> Stephan >>> >>> >>> >>> >>> On 05/20/2014 05:54 PM, Simone Tripodi wrote: >>>> Hi Stephan, >>>> >>>> I purged all those three artifacts and still got the same issue :( >>>> >>>> Looks like it's a problem on my machine (that I will try to fix >>>> anyway), so I am +1 to graduate from sandbox - to you the honour to >>>> move persist under the main trunk development :) >>>> >>>> Alles Gute! >>>> -Simo >>>> http://people.apache.org/~simonetripodi/ >>>> http://twitter.com/simonetripodi >>>> >>>> >>>> On Tue, May 20, 2014 at 3:32 PM, Stephan Classen <st.clas...@gmx.ch> >>>> wrote: >>>>> I see the following in the gist: >>>>> >>>>> [WARNING] error: error reading >>>>> /Users/stripodi/.m2/repository/ch/qos/logback/logback-core/1.1.2/logback-core-1.1.2.jar; >>>>> >>>>> cannot read zip file entry >>>>> [WARNING] error: error reading >>>>> /Users/stripodi/.m2/repository/org/hibernate/hibernate-core/4.3.5.Final/hibernate-core-4.3.5.Final.jar; >>>>> >>>>> cannot read zip file entry >>>>> [WARNING] error: error reading >>>>> /Users/stripodi/.m2/repository/org/jboss/jandex/1.1.0.Final/jandex-1.1.0.Final.jar; >>>>> >>>>> cannot read zip file entry >>>>> >>>>> could you remove the 3 jars from your local repository and have maven >>>>> download them again. >>>>> The class not found errors match classes which are located in the >>>>> above jars >>>>> >>>>> Thx >>>>> Stephan >>>>> >>>>> >>>>> >>>>> On 05/20/2014 02:44 PM, Simone Tripodi wrote: >>>>>> Hi Stephan, >>>>>> >>>>>> there's a Classloader issue I guess, I pasted the console output of >>>>>> `mvn clean install` execution on a public gist[1] just to make it >>>>>> easier to have a look at it. >>>>>> Unfortunately, I have no idea why they behave differently - and maybe >>>>>> I am one of the mast man on hearth that has never used Hibernate :( >>>>>> >>>>>> Thanks a lot for your help, much more than appreciated! >>>>>> -Simo >>>>>> >>>>>> https://gist.github.com/simonetripodi/0c0da3de5594793fe11e >>>>>> http://people.apache.org/~simonetripodi/ >>>>>> http://twitter.com/simonetripodi >>>>>> >>>>>> >>>>>> On Tue, May 20, 2014 at 7:39 AM, Stephan Classen <st.clas...@gmx.ch> >>>>>> wrote: >>>>>>> Hi Simone >>>>>>> >>>>>>> I was able to use the Mac of a friend. >>>>>>> Downloaded the source from the SVN and did a "mvn clean install" -> >>>>>>> Build >>>>>>> Success >>>>>>> >>>>>>> Here the details of his environment: >>>>>>> >>>>>>> Apache Maven 3.0.3 (r1075438; 2011-02-28 18:31:09+0100) >>>>>>> Maven home: /usr/share/maven >>>>>>> >>>>>>> Java version: 1.6.0_65, vendor: Apple Inc. >>>>>>> Java home: >>>>>>> /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home >>>>>>> Default locale: en_US, platform encoding: MacRoman >>>>>>> OS name: "mac os x", version: "10.8.5", arch: "x86_64", family: "mac" >>>>>>> >>>>>>> It is not exactly the same maven version. But I feel that the class >>>>>>> not >>>>>>> found exceptions >>>>>>> have some other source than maven. >>>>>>> >>>>>>> Simone do you have an idea why you system behaves differently then the >>>>>>> ones >>>>>>> I use for >>>>>>> testing? >>>>>>> >>>>>>> >>>>>>> Cheers >>>>>>> Stephan >>>>>>> >>>>>>> >>>>>>> >>>>>>> On 05/19/2014 02:11 PM, Simone Tripodi wrote: >>>>>>>> Hi again Stephan, >>>>>>>> >>>>>>>> I had an overview on what you did and just have one single word: WOW! >>>>>>>> >>>>>>>> Congrats and thanks a lot for taking care of such HUGE amount of >>>>>>>> code, >>>>>>>> it is *impressive*! >>>>>>>> Before to move outside the sandbox I think we need to quickly discuss >>>>>>>> two small things:] >>>>>>>> >>>>>>>> * both PersistenceService#start() and UnitOfWork#begin() throw >>>>>>>> IllegalStateException: IMHO there's no need to add such exception in >>>>>>>> methods signature, being an unchecked exception, but I'd leave in the >>>>>>>> comment the advertisement for consumers that implementations may >>>>>>>> throw >>>>>>>> runtime errors; >>>>>>>> >>>>>>>> * when running `mvn clean install` I got few errors: >>>>>>>> >>>>>>>> Tests in error: >>>>>>>> >>>>>>>> >>>>>>>> EntityManagerFactoryFactoryTest.shouldCreateAnInstanceWithThePassedValues:63 >>>>>>>> >>>>>>>> ? NoClassDefFound >>>>>>>> >>>>>>>> >>>>>>>> NestedTransactionTest.testNestedTransactions:357->doTestNestedTransaction:376 >>>>>>>> >>>>>>>> ? NoClassDefFound >>>>>>>> SingleTransactionTest.setUp:61 ? NoClassDefFound Could not >>>>>>>> initialize class or... >>>>>>>> SingleTransactionTest.setUp:61 ? NoClassDefFound Could not >>>>>>>> initialize class or... >>>>>>>> SingleTransactionTest.setUp:61 ? NoClassDefFound Could not >>>>>>>> initialize class or... >>>>>>>> SingleTransactionTest.setUp:61 ? NoClassDefFound Could not >>>>>>>> initialize class or... >>>>>>>> SingleTransactionTest.setUp:61 ? NoClassDefFound Could not >>>>>>>> initialize class or... >>>>>>>> SingleTransactionTest.setUp:61 ? NoClassDefFound Could not >>>>>>>> initialize class or... >>>>>>>> SingleTransactionTest.setUp:61 ? NoClassDefFound Could not >>>>>>>> initialize class or... >>>>>>>> SingleTransactionTest.setUp:61 ? NoClassDefFound Could not >>>>>>>> initialize class or... >>>>>>>> SingleTransactionTest.setUp:61 ? NoClassDefFound Could not >>>>>>>> initialize class or... >>>>>>>> SingleTransactionTest.setUp:61 ? NoClassDefFound Could not >>>>>>>> initialize class or... >>>>>>>> SingleTransactionTest.setUp:61 ? NoClassDefFound Could not >>>>>>>> initialize class or... >>>>>>>> SingleTransactionTest.setUp:61 ? NoClassDefFound Could not >>>>>>>> initialize class or... >>>>>>>> >>>>>>>> This is the environment where I ran tests: >>>>>>>> >>>>>>>> Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; >>>>>>>> 2013-02-19 14:51:28+0100) >>>>>>>> Maven home: /Applications/apache-maven-3.0.5 >>>>>>>> Java version: 1.6.0_65, vendor: Apple Inc. >>>>>>>> Java home: >>>>>>>> /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home >>>>>>>> Default locale: en_US, platform encoding: MacRoman >>>>>>>> OS name: "mac os x", version: "10.8.5", arch: "x86_64", family: "mac" >>>>>>>> >>>>>>>> Once clarified these two points, I think we can go outside the >>>>>>>> sandbox >>>>>>>> :) >>>>>>>> >>>>>>>> Thanks once again for the extraordinary effort on persist!!! >>>>>>>> Alles Gute! >>>>>>>> -Simo >>>>>>>> >>>>>>>> http://people.apache.org/~simonetripodi/ >>>>>>>> http://twitter.com/simonetripodi >>>>>>>> >>>>>>>> >>>>>>>> On Mon, May 19, 2014 at 9:00 AM, Stephan Classen <st.clas...@gmx.ch> >>>>>>>> wrote: >>>>>>>>> Please, take your time. >>>>>>>>> I invested about every minute of my spear time since Christmas into >>>>>>>>> this >>>>>>>>> code. >>>>>>>>> >>>>>>>>> What would you suggest would be an adequate amount of time? >>>>>>>>> >>>>>>>>> Cheers >>>>>>>>> Stephan >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On 05/18/2014 04:03 PM, Eric Charles wrote: >>>>>>>>>> I would rather leave the vote open for more days to give more >>>>>>>>>> change >>>>>>>>>> for >>>>>>>>>> reviews. >>>>>>>>>> Thx, Eric >>>>>>>>>> >>>>>>>>>> On 05/17/2014 08:39 PM, Stephan Classen wrote: >>>>>>>>>>> With only one vote in favor the voting has failled and onami >>>>>>>>>>> persist >>>>>>>>>>> will >>>>>>>>>>> stay in sandbox. >>>>>>>>>>> >>>>>>>>>>> I would appreciate any hint on how to improve onami persist. >>>>>>>>>>> >>>>>>>>>>> Cheers >>>>>>>>>>> Stephan >>>>>>>>>>> >>>>>>>>>>> Am 13.05.2014 22:20 schrieb Stephan Classen <st.clas...@gmx.ch>: >>>>>>>>>>>> Hi all devs. >>>>>>>>>>>> >>>>>>>>>>>> Apache Onami persist has come great ways. >>>>>>>>>>>> - Code is clean >>>>>>>>>>>> - Unit test coverage is high >>>>>>>>>>>> - Integration test coverage still needs some improvement >>>>>>>>>>>> - Documentation is plentiful >>>>>>>>>>>> >>>>>>>>>>>> So I feel it is time to release it into the wild. >>>>>>>>>>>> >>>>>>>>>>>> Vote will be open for at least 72h and closes ~ May the 16th, at >>>>>>>>>>>> 8:00pm >>>>>>>>>>>> GMT. >>>>>>>>>>>> Many thanks in advance for reviewing >>>>>>>>>>>> >>>>>>>>>>>> Stephan >>>>>>>>>>>> >>>
