----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4412/#review6185 -----------------------------------------------------------
Ship it! LGTM - Chris On 2012-03-20 08:06:42, brian Foster wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4412/ > ----------------------------------------------------------- > > (Updated 2012-03-20 08:06:42) > > > Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and > Thomas Bennett. > > > Summary > ------- > > This is the CAS-Metadata part of this issue > > > This addresses bug OODT-426. > https://issues.apache.org/jira/browse/OODT-426 > > > Diffs > ----- > > > trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/exceptions/NamingConventionException.java > PRE-CREATION > > trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/filenaming/NamingConvention.java > PRE-CREATION > > trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/filenaming/PathUtilsNamingConvention.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4412/diff > > > Testing > ------- > > Still need to add unit-test for PathUtilsNamingConvention > > > Thanks, > > brian > >
