----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10288/#review19508 -----------------------------------------------------------
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/assembly/assembly.xml <https://reviews.apache.org/r/10288/#comment40253> do we really need solr schema as a resource? This would suggest it gets shipped by default inside of e.g., $FILEMGR_HOME/etc. http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/CompleteProduct.java <https://reviews.apache.org/r/10288/#comment40254> Agree with Paul/Luca here -- let's try and reuse this and refactor out of LuceneCatalog and use for both here. http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/DefaultProductSerializer.java <https://reviews.apache.org/r/10288/#comment40255> I see you've turned this into an interface. Do you expect many people to extend this? I'm more of a fan of keeping things concrete, until it's needed (e.g., at least 2 implementations) to make something an interface. Thoughts about this not implementing ProductSerializer, and removing it as an interface? http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/DefaultProductSerializer.java <https://reviews.apache.org/r/10288/#comment40257> why skip? http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/OODT_SOLR_README.TXT <https://reviews.apache.org/r/10288/#comment40258> +1 http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/QUICK_START_GUIDE.TXT <https://reviews.apache.org/r/10288/#comment40259> I see why it's in etc, +1 then - Chris Mattmann On April 4, 2013, 8:03 p.m., Luca Cinquini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10288/ > ----------------------------------------------------------- > > (Updated April 4, 2013, 8:03 p.m.) > > > Review request for oodt and Chris Mattmann. > > > Description > ------- > > This Catalog sub-package provides an extensible set of functionality that > allows a CAS File Manager to store and query metadata to/from a standalone > Solr server. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/assembly/assembly.xml > 1463907 > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/CompleteProduct.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/DefaultProductDeserializer.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/DefaultProductSerializer.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/NameProductIdGenerator.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/OODT_SOLR_README.TXT > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/Parameters.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/ProductDeserializer.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/ProductIdGenerator.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/ProductSerializer.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/QUICK_START_GUIDE.TXT > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/QueryResponse.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrCatalog.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrCatalogFactory.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrClient.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/UUIDProductIdGenerator.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/filemgr.properties > 1464226 > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/schema.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/10288/diff/ > > > Testing > ------- > > Tested ingestion and querying of simple products of type 'GenericFile', as > well as products generated by the VFASTR pipeline (but without splitting them > in separate documents for Job/Scan/Event information). > Included draft documentation for Apache wiki: quick start guide and in-depth > architecture guide. > > > Thanks, > > Luca Cinquini > >
