----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10288/#review19510 -----------------------------------------------------------
http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrCatalogFactory.java <https://reviews.apache.org/r/10288/#comment40260> You may want to do PathUtils.replaceEnvVariables on this string to allow for env var replacement, but maybe that's overkill. http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrCatalogFactory.java <https://reviews.apache.org/r/10288/#comment40261> probably worth putting this in o.a.oodt.cas.filemgr.util.GenericFileManagerObjectFatory so that construction of key extension points can be limited to a single factory class. Or maybe worth providing a SolrCatalogObjectFactory.createProductSerializer(String serviceFactoryClassName) http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrCatalogFactory.java <https://reviews.apache.org/r/10288/#comment40262> Same comment here as above for the serializer. Also it may be worth combining these into the same interface, b/c you always see "SerDe" implicating that Serializers and DeSerializers go together. Letting folks set different ones introduces the potential for them to set ones that are incompat with one another. http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrClient.java <https://reviews.apache.org/r/10288/#comment40263> SolrJ is a definite option here. One thing it allows for is binary compatible SerDe which we'd have to reimplement. That said, I get Luca's point to (since the way he did it would allow OPeNDAPps to generate Solr XML from OODT profiles and then pipe to Solr which is nice too. It all boils down to whether or not Luca is willing to maintain this SolrClient and it seems like for now that he is. Now, we need 2 other guys at least to be willing to (any volunteers?) :) - Chris Mattmann On April 4, 2013, 8:03 p.m., Luca Cinquini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10288/ > ----------------------------------------------------------- > > (Updated April 4, 2013, 8:03 p.m.) > > > Review request for oodt and Chris Mattmann. > > > Description > ------- > > This Catalog sub-package provides an extensible set of functionality that > allows a CAS File Manager to store and query metadata to/from a standalone > Solr server. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/assembly/assembly.xml > 1463907 > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/CompleteProduct.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/DefaultProductDeserializer.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/DefaultProductSerializer.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/NameProductIdGenerator.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/OODT_SOLR_README.TXT > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/Parameters.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/ProductDeserializer.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/ProductIdGenerator.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/ProductSerializer.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/QUICK_START_GUIDE.TXT > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/QueryResponse.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrCatalog.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrCatalogFactory.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrClient.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/UUIDProductIdGenerator.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/filemgr.properties > 1464226 > > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/schema.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/10288/diff/ > > > Testing > ------- > > Tested ingestion and querying of simple products of type 'GenericFile', as > well as products generated by the VFASTR pipeline (but without splitting them > in separate documents for Job/Scan/Event information). > Included draft documentation for Apache wiki: quick start guide and in-depth > architecture guide. > > > Thanks, > > Luca Cinquini > >
