[
https://issues.apache.org/jira/browse/OOZIE-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464990#comment-13464990
]
Virag Kothari commented on OOZIE-994:
-------------------------------------
The changes related to retries look good.
Some questions related to changes in registration of Exceptions.
{code}
- ERROR_INFOS.put(getType(), new LinkedHashMap<Class, ErrorInfo>());
+ ERROR_INFOS.put(getType(), new LinkedHashMap<String, Set<ErrorInfo>>());
{code}
registerError() will register a different Exception each time. I dont
understand why this change from a single ErrorInfo to a set of ErrorInfo is
required.
Also, the case when a super class is registered but the subclass is not will
not be handled.
E.g: Register only IOException. In the test case, throw RemoteException.
Previously the convertException() would catch the RemoteException as a subclass
of IO. But now it wont as all the error's are not being iterated over.
> ActionCheckXCommand does not handle failures properly
> -----------------------------------------------------
>
> Key: OOZIE-994
> URL: https://issues.apache.org/jira/browse/OOZIE-994
> Project: Oozie
> Issue Type: Bug
> Components: workflow
> Affects Versions: 3.2.0
> Reporter: Alejandro Abdelnur
> Assignee: Robert Kanter
> Priority: Critical
> Fix For: trunk
>
> Attachments: OOZIE-994.patch, OOZIE-994.patch, OOZIE-994.patch,
> OOZIE-994.patch, OOZIE-994.patch
>
>
> If the JT restarts or dies and running jobs are lost or the JT is not
> reachable, Oozie ActionCheckXCommand will never fail the workflow job.
> There seem to be 2 issues here:
> * convertException is not receiving the root cause exception anytmore, but
> alway HadoopAccessorException wrapping the root cause exception. We should
> modify the convertException to inspect the cause exception as well.
> * ActionCheckXCommand does not do the handle retry logic of
> ActionStartXCommand.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
