[
https://issues.apache.org/jira/browse/OOZIE-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465857#comment-13465857
]
Virag Kothari commented on OOZIE-994:
-------------------------------------
This patch looks good. It is similar to your original patch with two for loops.
I am fine with either of them. It seems like it is non-trivial to get rid of
one loop and also not rely on exception ordering.
If you are going ahead with this one, some minor comments:
* Remove unused imports (HashSEt, set)
* The new parameter 'Class' should be parameterized (Class<?>)
* The two input parameters to convertExceptionHelper seems dependent on each
other. Probably you can pass one and let the other one derive from it.
* Remove @SuppressWarnings("deprecation") from patch in TestActionCheckX
+1 after addressing comments
> ActionCheckXCommand does not handle failures properly
> -----------------------------------------------------
>
> Key: OOZIE-994
> URL: https://issues.apache.org/jira/browse/OOZIE-994
> Project: Oozie
> Issue Type: Bug
> Components: workflow
> Affects Versions: 3.2.0
> Reporter: Alejandro Abdelnur
> Assignee: Robert Kanter
> Priority: Critical
> Fix For: trunk
>
> Attachments: OOZIE-994.patch, OOZIE-994.patch, OOZIE-994.patch,
> OOZIE-994.patch, OOZIE-994.patch, OOZIE-994.patch
>
>
> If the JT restarts or dies and running jobs are lost or the JT is not
> reachable, Oozie ActionCheckXCommand will never fail the workflow job.
> There seem to be 2 issues here:
> * convertException is not receiving the root cause exception anytmore, but
> alway HadoopAccessorException wrapping the root cause exception. We should
> modify the convertException to inspect the cause exception as well.
> * ActionCheckXCommand does not do the handle retry logic of
> ActionStartXCommand.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
