-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7985/#review13452
-----------------------------------------------------------



branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java
<https://reviews.apache.org/r/7985/#comment28818>

    it should be getPushmissingdependency



branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java
<https://reviews.apache.org/r/7985/#comment28821>

    since it will come from push missing dependency, it is expected to be 
HCatURI. We might need to add a combo method that deals with list of uris 
instead of one uri.
    



branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java
<https://reviews.apache.org/r/7985/#comment28820>

    what will happen to else. at least add some log.info



branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
<https://reviews.apache.org/r/7985/#comment28823>

    in addition, some place you need to store the chat based dependency list 
into pushMisiisgDep field.



branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
<https://reviews.apache.org/r/7985/#comment28824>

    else part?



branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
<https://reviews.apache.org/r/7985/#comment28825>

    same else part?



branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
<https://reviews.apache.org/r/7985/#comment28826>

    ditto



branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
<https://reviews.apache.org/r/7985/#comment28827>

    ditto



branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
<https://reviews.apache.org/r/7985/#comment28828>

    ditto


- Mohammad Islam


On Nov. 14, 2012, 8:25 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7985/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2012, 8:25 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> note still work in progress, with lots of comment out.
> https://issues.apache.org/jira/browse/OOZIE-1043
> 
> 
> This addresses bug OOZIE-1043.
>     https://issues.apache.org/jira/browse/OOZIE-1043
> 
> 
> Diffs
> -----
> 
>   
> branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java
>  1409046 
>   
> branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  1409046 
>   
> branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
>  1409046 
>   
> branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordCommandUtils.java
>  PRE-CREATION 
>   
> branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java
>  1409046 
> 
> Diff: https://reviews.apache.org/r/7985/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Reply via email to