----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7985/#review13542 -----------------------------------------------------------
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java <https://reviews.apache.org/r/7985/#comment29097> minor comment: please rename the variable 'tmp' tp something meaningful. branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java <https://reviews.apache.org/r/7985/#comment29099> minor: 'fals' is too generic. give some meaningful var name. branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java <https://reviews.apache.org/r/7985/#comment29098> Please use HCatURI static method for verifying is something starts with hcat:// branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java <https://reviews.apache.org/r/7985/#comment29100> it appears the "formatting was not applied to the patch. Please apple the oozie-formatting.xml file int he project level. branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java <https://reviews.apache.org/r/7985/#comment29101> should we return here? branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7985/#comment29103> Wandering : is there any other place where we use the similar code (most possibly partitionAvailable()). If yes, we could reuse some of those pieces of code. branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7985/#comment29102> do we need to check if uri.length() > 0 before calling it. - Mohammad Islam On Nov. 16, 2012, 8:05 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7985/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2012, 8:05 p.m.) > > > Review request for oozie. > > > Description > ------- > > note still work in progress, with lots of comment out. > https://issues.apache.org/jira/browse/OOZIE-1043 > > > This addresses bug OOZIE-1043. > https://issues.apache.org/jira/browse/OOZIE-1043 > > > Diffs > ----- > > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1409046 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1409046 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 1409046 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordCommandUtils.java > PRE-CREATION > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > 1409046 > > Diff: https://reviews.apache.org/r/7985/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
