> On Dec. 4, 2012, 9 a.m., Ryota Egashira wrote: > > http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/main/java/org/apache/oozie/tools/workflowgenerator/client/OozieWorkflowGenerator.java, > > line 580 > > <https://reviews.apache.org/r/8236/diff/1/?file=231199#file231199line580> > > > > need to apply oozie formatter.
Hi Ryota, will use formatter. could you also show me what exactly wrong with the line 579? > On Dec. 4, 2012, 9 a.m., Ryota Egashira wrote: > > http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/main/java/org/apache/oozie/tools/workflowgenerator/client/OozieWorkflowGenerator.java, > > line 576 > > <https://reviews.apache.org/r/8236/diff/1/?file=231199#file231199line576> > > > > yes, as you indicated, we shouldn't hard-code version number, need to > > dynamically get version number from pom. > > this might help? > > > > http://stackoverflow.com/questions/3697449/retrieve-version-from-maven-pom-xml-in-code Hi Ryota, the tip helps! will look into it! - jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8236/#review14014 ----------------------------------------------------------- On Nov. 27, 2012, 6:11 p.m., jun aoki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8236/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2012, 6:11 p.m.) > > > Review request for oozie. > > > Description > ------- > > Help -> About shows a popup with a hardcoded version number. > > > This addresses bug OOZIE-1083. > https://issues.apache.org/jira/browse/OOZIE-1083 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/main/java/org/apache/oozie/tools/workflowgenerator/client/OozieWorkflowGenerator.java > 1414290 > > http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/test/java/org/apache/oozie/tools/workflowgenerator/client/OozieWorkflowGeneratorTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/8236/diff/ > > > Testing > ------- > > Locally tested > > > Thanks, > > jun aoki > >
