----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8236/ -----------------------------------------------------------
(Updated Dec. 7, 2012, 4:13 a.m.) Review request for oozie. Changes ------- Uploading a new patch. It is getting more interesting. 1. Getting a wfgen version, I used this technique http://stackoverflow.com/questions/3697449/retrieve-version-from-maven-pom-xml-in-code It occurs at process-resources maven phase and generates a .properties file with some info from pom. It looks a good practice. 2. Since it is a build time process and only GWT server can access to the .properties file, GWT RPC is used to pass the version number to the GWT client. (I got confused but GWT has a concept of client and server, and client means a class that is translated into javascript, therefore, no way to access server side local resources such as a properties file. Description ------- Help -> About shows a popup with a hardcoded version number. This addresses bug OOZIE-1083. https://issues.apache.org/jira/browse/OOZIE-1083 Diffs (updated) ----- http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/pom.xml 1418180 http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/main/java/org/apache/oozie/tools/workflowgenerator/client/OozieWorkflowGenerator.java 1418180 http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/main/java/org/apache/oozie/tools/workflowgenerator/client/rpc/WFGenPropertiesService.java PRE-CREATION http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/main/java/org/apache/oozie/tools/workflowgenerator/client/rpc/WFGenPropertiesServiceAsync.java PRE-CREATION http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/main/java/org/apache/oozie/tools/workflowgenerator/server/WFGenProperties.java PRE-CREATION http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/main/java/org/apache/oozie/tools/workflowgenerator/server/WFGenPropertiesServiceImpl.java PRE-CREATION http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/main/resources/workflowgenerator.properties PRE-CREATION http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/main/webapp/WEB-INF/web.xml 1418180 http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/test/java/org/apache/oozie/tools/workflowgenerator/client/OozieWorkflowGeneratorTest.java PRE-CREATION Diff: https://reviews.apache.org/r/8236/diff/ Testing ------- Locally tested Thanks, jun aoki
