----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8618/#review14577 -----------------------------------------------------------
Ran the testcases after following the comments in JIRA. All test cases run and pass. Few comments below.. http://svn.apache.org/repos/asf/oozie/trunk/core/pom.xml <https://reviews.apache.org/r/8618/#comment31008> This is the commit build profile. Its better to keep this test excluded http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java <https://reviews.apache.org/r/8618/#comment31006> why is this block of code added? http://svn.apache.org/repos/asf/oozie/trunk/tests/pom.xml <https://reviews.apache.org/r/8618/#comment31007> above dependency seems a duplicate of this. Is it required? - Virag Kothari On Dec. 15, 2012, 10:07 p.m., Rohini Palaniswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8618/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2012, 10:07 p.m.) > > > Review request for oozie. > > > Description > ------- > > Moved pig unit tests to a separate module so hive and hcat dependency tests > can be run in core. > > Additional steps while checkin: > patch -p0 < OOZIE-1124.patch > mkdir -p tests/pig/src/test/java/org/apache/oozie/action/hadoop > svn add tests > svn mv > core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java > tests/pig/src/test/java/org/apache/oozie/action/hadoop > > > This addresses bug OOZIE-1124. > https://issues.apache.org/jira/browse/OOZIE-1124 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/oozie/trunk/core/pom.xml 1422033 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java > 1422033 > > http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/ENG_Building.twiki > 1422033 > http://svn.apache.org/repos/asf/oozie/trunk/pom.xml 1422033 > http://svn.apache.org/repos/asf/oozie/trunk/tests/pig/pom.xml PRE-CREATION > http://svn.apache.org/repos/asf/oozie/trunk/tests/pom.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/8618/diff/ > > > Testing > ------- > > Now TestHive*.java tests also run as part of the normal build > > > Thanks, > > Rohini Palaniswamy > >
