> On Dec. 17, 2012, 7:33 a.m., Virag Kothari wrote: > > http://svn.apache.org/repos/asf/oozie/trunk/core/pom.xml, line 550 > > <https://reviews.apache.org/r/8618/diff/1/?file=239058#file239058line550> > > > > This is the commit build profile. Its better to keep this test excluded
Its good to have hive test cases as part of the commit build as it is critical functionality. Only reason I see it was excluded before was because of conflict with pig. > On Dec. 17, 2012, 7:33 a.m., Virag Kothari wrote: > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java, > > line 102 > > <https://reviews.apache.org/r/8618/diff/1/?file=239059#file239059line102> > > > > why is this block of code added? This is required to determine the core directory (when module under test is two levels down from core) from which lot of config files are picked up later in the code. Fixing it properly would require ripping out lot of code further to actually pick those files from classpath instead of looking under core directory. Did not want to touch too much code. So went with the easiest fix. > On Dec. 17, 2012, 7:33 a.m., Virag Kothari wrote: > > http://svn.apache.org/repos/asf/oozie/trunk/tests/pom.xml, line 46 > > <https://reviews.apache.org/r/8618/diff/1/?file=239063#file239063line46> > > > > above dependency seems a duplicate of this. Is it required? Both are different. one is oozie-core.jar and other is oozie-core-test.jar - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8618/#review14577 ----------------------------------------------------------- On Dec. 15, 2012, 10:07 p.m., Rohini Palaniswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8618/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2012, 10:07 p.m.) > > > Review request for oozie. > > > Description > ------- > > Moved pig unit tests to a separate module so hive and hcat dependency tests > can be run in core. > > Additional steps while checkin: > patch -p0 < OOZIE-1124.patch > mkdir -p tests/pig/src/test/java/org/apache/oozie/action/hadoop > svn add tests > svn mv > core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java > tests/pig/src/test/java/org/apache/oozie/action/hadoop > > > This addresses bug OOZIE-1124. > https://issues.apache.org/jira/browse/OOZIE-1124 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/oozie/trunk/core/pom.xml 1422033 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java > 1422033 > > http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/ENG_Building.twiki > 1422033 > http://svn.apache.org/repos/asf/oozie/trunk/pom.xml 1422033 > http://svn.apache.org/repos/asf/oozie/trunk/tests/pig/pom.xml PRE-CREATION > http://svn.apache.org/repos/asf/oozie/trunk/tests/pom.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/8618/diff/ > > > Testing > ------- > > Now TestHive*.java tests also run as part of the normal build > > > Thanks, > > Rohini Palaniswamy > >
