----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8769/#review15030 -----------------------------------------------------------
Can we order all the dataIn functions first followed by dataOut? branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html <https://reviews.apache.org/r/8769/#comment32566> "Refer to the Example below for usage". Other places too. branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html <https://reviews.apache.org/r/8769/#comment32567> action tag in next line branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html <https://reviews.apache.org/r/8769/#comment32568> Can we move this not to dataInPartitionPigFilter section branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html <https://reviews.apache.org/r/8769/#comment32569> The EL function should not be adding the quotes. if that's case can you fix the EL function and update the example by putting the quotes manually - That is the first comment when I read this. Then realized you were just mentioning how arguments are passed to pig. Kind of confusing as to whether you need to put quotes or not. Would be better to remove the comment as the example is clear on the usage. branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html <https://reviews.apache.org/r/8769/#comment32570> $region here too branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html <https://reviews.apache.org/r/8769/#comment32571> Can you also add datestamp to this example along with region. Does not make sense if the uri definition has datestamp and it is not used here. branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki <https://reviews.apache.org/r/8769/#comment32573> coordinator actions running workflows? branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki <https://reviews.apache.org/r/8769/#comment32574> remove commonly branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki <https://reviews.apache.org/r/8769/#comment32575> Remove commonly branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki <https://reviews.apache.org/r/8769/#comment32576> The filter clause format is specific to pig and hence the EL function name.... - note here. branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki <https://reviews.apache.org/r/8769/#comment32577> for the output-event dataset. This can be passed as an argument to HCatStorer in pig scripts. branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki <https://reviews.apache.org/r/8769/#comment32578> using the EL functions. input partitions pig filter branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki <https://reviews.apache.org/r/8769/#comment32579> Can we make it 24 instead of 5 to make it consistent with hourly to daily processing branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki <https://reviews.apache.org/r/8769/#comment32581> Add a note asking to use dataInPartitionMin and Max to form a range fitler wherever possible instead of datainPartitionPigFilter as it will be more efficient for filtering. branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki <https://reviews.apache.org/r/8769/#comment32572> Can you also mention here, that this is another convenience function in addition to dataoutPartitions and either one can be used. branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki <https://reviews.apache.org/r/8769/#comment32580> remove ofcourse - Rohini Palaniswamy On Jan. 3, 2013, 2:53 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8769/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2013, 2:53 a.m.) > > > Review request for oozie. > > > Description > ------- > > See OOZIE-1123 for HCat EL functions description and implementation. This > patch is user documentation for usage > > > Diffs > ----- > > branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html > PRE-CREATION > branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki > 1426606 > > Diff: https://reviews.apache.org/r/8769/diff/ > > > Testing > ------- > > n/a > > > Thanks, > > Mona Chitnis > >
