> On Jan. 3, 2013, 6:20 p.m., Rohini Palaniswamy wrote: > > Can we order all the dataIn functions first followed by dataOut?
showing dataOut is needed to make both examples complete and usable directly. the second example then goes on to show min, max and dataOut for particular partition which are like additional convenience functions > On Jan. 3, 2013, 6:20 p.m., Rohini Palaniswamy wrote: > > branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html, line 3477 > > <https://reviews.apache.org/r/8769/diff/2/?file=244499#file244499line3477> > > > > The EL function should not be adding the quotes. if that's case can you > > fix the EL function and update the example by putting the quotes manually - > > That is the first comment when I read this. Then realized you were just > > mentioning how arguments are passed to pig. Kind of confusing as to whether > > you need to put quotes or not. Would be better to remove the comment as the > > example is clear on the usage. removing the comment to avoid confusion - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8769/#review15030 ----------------------------------------------------------- On Jan. 3, 2013, 2:53 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8769/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2013, 2:53 a.m.) > > > Review request for oozie. > > > Description > ------- > > See OOZIE-1123 for HCat EL functions description and implementation. This > patch is user documentation for usage > > > Diffs > ----- > > branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html > PRE-CREATION > branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki > 1426606 > > Diff: https://reviews.apache.org/r/8769/diff/ > > > Testing > ------- > > n/a > > > Thanks, > > Mona Chitnis > >
