[
https://issues.apache.org/jira/browse/OOZIE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555634#comment-13555634
]
jun aoki commented on OOZIE-894:
--------------------------------
Hi Bowen,
A few things
1. ScriptLanguageCommand "method" in OozieCLI should start with "s" instead of
"S"
2. In DagEngine it has "*" in an import statement. Is it a good coding
convention?
3. It tends to combine hive with pig as "ScriptLanguage". I am not too sure we
should combine them together. One good place I found it is not good is in
TestWorkflowXClient.java
{code}
wc.submitPig(conf, pigScriptFile, null)); // CURRENT WAY
wc.submitScriptLanguage(conf, pigScriptFile, null, "pig")); // IN THE PATCH
{code}
submitPig is a typed method whereas submitScriptLaunguage can take a string in
the 4th param, which is error prone.
Also my 2 cents, it is a big patch so maybe good idea to use reviewboard.
> support for hive in Oozie CLI
> -----------------------------
>
> Key: OOZIE-894
> URL: https://issues.apache.org/jira/browse/OOZIE-894
> Project: Oozie
> Issue Type: New Feature
> Components: client, workflow
> Affects Versions: 3.3.0
> Reporter: Alejandro Abdelnur
> Assignee: Bowen Zhang
> Fix For: trunk
>
> Attachments: oozie-894.patch
>
>
> add support for 'oozie hive' in the CLI
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
