[
https://issues.apache.org/jira/browse/OOZIE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13579390#comment-13579390
]
Alejandro Abdelnur commented on OOZIE-894:
------------------------------------------
Thanks Bowen, overall seems in good shape. Following my feedback.
* patch needs to be rebased, it does not apply cleanly
* OozieCLI.java, createScriptLanguageOptions()
** local var 'File' should be 'file'
** the logic to set pig or hive is a bit odd, it seems it would more natural to
pass the description as parameter, then no need to do an IF
* PigActionExecutor, why the scriptName static var? we can use directly the
PIG_SCRIPT constant.
* HiveActionExecutor, why the scriptName static var? we can use directly the
HIVE_SCRIPT constant.
* ScriptLanguageActionExecutor
** class should be abstract with getScriptName() method abstract
** comments/messages should state filesystem instead hdfs
** exception message should print the path that failed
* TestWorkflowXCLient, it should have a testSubmitHive() test
* V1JobsServlet
** we should use constants instead literals for pig/mapreduce/hive
** we should put pig/mapreduce/hive in a Set<String> and do contains() instead
the current IF statement
* XOozieClient, submitScripLanguage(), same as in OozieCLI, the logic is a bit
odd (setting PIG and then checking if Hive and reseting)
Finally, it seems it is not possible to do a submit patch for this JIRA (in
order to get test-patch to run), if you cannot do that, then open a new JIRA
and close this one as DUP.
> support for hive in Oozie CLI
> -----------------------------
>
> Key: OOZIE-894
> URL: https://issues.apache.org/jira/browse/OOZIE-894
> Project: Oozie
> Issue Type: New Feature
> Components: client, workflow
> Affects Versions: 3.3.0
> Reporter: Alejandro Abdelnur
> Assignee: Bowen Zhang
> Fix For: trunk
>
> Attachments: oozie-894.patch, oozie-894.patch
>
>
> add support for 'oozie hive' in the CLI
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
