----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9622/ -----------------------------------------------------------
(Updated March 23, 2013, 12:25 a.m.) Review request for oozie. Changes ------- Combining WorkflowJobSuccessMessage, WorkflowJobFailureMessage, WorkflowJobStartedMessage in WorkflowJobMessage Combining CoordinatorActionWaitingMessage, CoordinatorActionSuccessMessage, CoordinatorActionFailureMessage, CoordinatorActionStartedMessage in CoordinatorActionMessage WIP The WorkflowListener should have onWorkflowJobSuspend() Combining WfListener and coordListener in one init() and destroy() in listener Description ------- Description at https://issues.apache.org/jira/browse/OOZIE-1234 OOZIE-1209 generates events and handles them by calling appropriate listeners. This patch provides JMS implementation of those listeners. Also, the messages are serialized using JSON and there is a deserializer to construct the Java object back from json. This addresses bug OOZIE-1234. https://issues.apache.org/jira/browse/OOZIE-1234 Diffs (updated) ----- trunk/client/pom.xml 1459407 trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMSMessagingUtils.java PRE-CREATION trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMS_HEADER_CONSTANTS.java PRE-CREATION trunk/client/src/main/java/org/apache/oozie/client/event/jms/JSONMessageDeserializer.java PRE-CREATION trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java PRE-CREATION trunk/client/src/main/java/org/apache/oozie/client/event/messaging/CoordinatorActionMessage.java PRE-CREATION trunk/client/src/main/java/org/apache/oozie/client/event/messaging/EventMessage.java PRE-CREATION trunk/client/src/main/java/org/apache/oozie/client/event/messaging/WorkflowJobMessage.java PRE-CREATION trunk/core/pom.xml 1459407 trunk/core/src/main/java/org/apache/oozie/event/messaging/JSONMessageSerializer.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageSerializer.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java 1459407 trunk/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java 1459407 trunk/core/src/main/java/org/apache/oozie/jms/JMSCoordEventListener.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java 1459407 trunk/core/src/main/java/org/apache/oozie/jms/JMSWorkflowEventListener.java PRE-CREATION trunk/core/src/test/java/org/apache/oozie/jms/TestJMSCoordinatorEventListener.java PRE-CREATION trunk/core/src/test/java/org/apache/oozie/jms/TestJMSWorkflowEventListener.java PRE-CREATION trunk/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 1459407 Diff: https://reviews.apache.org/r/9622/diff/ Testing ------- Unit test cases added. Test case for JMS connection failure pending. End to end test pending Thanks, Virag Kothari
