----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9622/#review18580 -----------------------------------------------------------
Will do the rest later. trunk/client/pom.xml <https://reviews.apache.org/r/9622/#comment38971> remove it pls. trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMS_HEADER_CONSTANTS.java <https://reviews.apache.org/r/9622/#comment38976> Class name all upper case. was it intentional? We have similar const file "RestConstants.java". trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMS_HEADER_CONSTANTS.java <https://reviews.apache.org/r/9622/#comment38978> I brought up another discussion on these multiple user-facing terms in Mona's patch. Can you please see that? We need to consider usability too. trunk/client/src/main/java/org/apache/oozie/client/event/jms/JSONMessageDeserializer.java <https://reviews.apache.org/r/9622/#comment38982> try to write through log.throw.... trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java <https://reviews.apache.org/r/9622/#comment38980> try to print both. because it will not be clear which one is null. trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java <https://reviews.apache.org/r/9622/#comment38981> I assume these are WIP. or they will be implemented later. If it will be implemented later, please thrown a Unsupported exception for all. - Mohammad Islam On March 28, 2013, 2:36 a.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9622/ > ----------------------------------------------------------- > > (Updated March 28, 2013, 2:36 a.m.) > > > Review request for oozie. > > > Description > ------- > > Description at https://issues.apache.org/jira/browse/OOZIE-1234 > > OOZIE-1209 generates events and handles them by calling appropriate > listeners. This patch provides JMS implementation of those listeners. Also, > the messages are serialized using JSON and there is a deserializer to > construct the Java object back from json. > > > This addresses bug OOZIE-1234. > https://issues.apache.org/jira/browse/OOZIE-1234 > > > Diffs > ----- > > trunk/client/pom.xml 1459407 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMSMessagingUtils.java > PRE-CREATION > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMS_HEADER_CONSTANTS.java > PRE-CREATION > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JSONMessageDeserializer.java > PRE-CREATION > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java > PRE-CREATION > > trunk/client/src/main/java/org/apache/oozie/client/event/messaging/CoordinatorActionMessage.java > PRE-CREATION > > trunk/client/src/main/java/org/apache/oozie/client/event/messaging/EventMessage.java > PRE-CREATION > > trunk/client/src/main/java/org/apache/oozie/client/event/messaging/JobMessage.java > PRE-CREATION > > trunk/client/src/main/java/org/apache/oozie/client/event/messaging/WorkflowJobMessage.java > PRE-CREATION > trunk/core/pom.xml 1459407 > > trunk/core/src/main/java/org/apache/oozie/event/messaging/JSONMessageSerializer.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageSerializer.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java > 1459407 > trunk/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java > 1459407 > trunk/core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java > 1459407 > trunk/core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/jms/TestDefaultConnectionContext.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java > 1459407 > > Diff: https://reviews.apache.org/r/9622/diff/ > > > Testing > ------- > > Unit test cases added. Test case for JMS connection failure pending. End to > end test pending > > > Thanks, > > Virag Kothari > >
