----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9602/#review18566 -----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java <https://reviews.apache.org/r/9602/#comment38916> so many type and status. do we need so many thing? it might confuse the people. Pls give a second thought in this line. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java <https://reviews.apache.org/r/9602/#comment38917> General comment: If possible, reduce the # of such DB calls which are heavy weight. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java <https://reviews.apache.org/r/9602/#comment38919> The same line as mentioned before. Consider a use-case: Oozie is not configured for any Event handling. But this type of DB access will be used. My proposal : 1. Try to minimize this. Found already done few places. 2. If you have to call such, call it only if Event service is turned on. By default, this should not be called. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java <https://reviews.apache.org/r/9602/#comment38918> if event handler service is turned off, it will throw NPE. Assumption: Event handler service is not must. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java <https://reviews.apache.org/r/9602/#comment38920> Add "&& misstep.length() > 0" trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java <https://reviews.apache.org/r/9602/#comment38921> same as before trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java <https://reviews.apache.org/r/9602/#comment38922> same logic as before for NPW. - Mohammad Islam On March 29, 2013, 3:35 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9602/ > ----------------------------------------------------------- > > (Updated March 29, 2013, 3:35 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1209 > WIP patch > > > This addresses bug OOZIE-1209. > https://issues.apache.org/jira/browse/OOZIE-1209 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1461403 > trunk/client/src/main/java/org/apache/oozie/client/event/Event.java > PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java > PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > 1461403 > trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java > 1461403 > trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java > 1461403 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1461403 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1461403 > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > 1461403 > trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java > 1461403 > > trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java > PRE-CREATION > trunk/core/src/main/resources/oozie-default.xml 1461403 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java > 1461403 > trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/9602/diff/ > > > Testing > ------- > > More unit tests to be added > > > Thanks, > > Mona Chitnis > >
