> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, > > line 119 > > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line119> > > > > what does it mean? WF_JOB and COORD_ACTION is must? > > > > If someone wants *only* COORD_JOB. How will it be achieved? > > Mona Chitnis wrote: > The rationale was that WF_JOB and COORD_ACTION would be the most common > use-case. In this case *only* COORD_JOB is not possible. But on the receiving > end, user can filter incoming messages on app-type COORD_JOB and it is > achieved.
So we are enforcing to create both message while user doesn't care one type. A lot of extra unnecessary messages will be there. Is there any other reason? > On April 1, 2013, 4:06 a.m., Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, > > line 91 > > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line91> > > > > Is this a right approach? Just report the failure. shoudl it fail the > > whole service? > > I'm sure also. Do you? > > > > Mona Chitnis wrote: > The error could arise from a mistyped or non-existent class in the config > properties. We wouldnt want the whole service to fail in that case. There > will be a default listener anyway ok > On April 1, 2013, 4:06 a.m., Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, > > line 85 > > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line85> > > > > is it possible, 'listernerclass' could be 'null'. in that case add > > "listernerClass != null && i <linsternerClass.lentgth) > > Mona Chitnis wrote: > Will be adding a default implementation for the listener (part of the > other JIRA for JMS listener), in which case 'listenerclass' wont be null ok. > On April 1, 2013, 4:06 a.m., Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java, > > line 62 > > <https://reviews.apache.org/r/9602/diff/7/?file=276752#file276752line62> > > > > How the user will know if it is DOENWITH ERROR or KEILLED? Any message > > text associated with that could be helpful. > > Mona Chitnis wrote: > the line above the switch case ladder sets the "actual" status, i.e. > DONEWITHERROR, KILLED etc. User will know from the 'status' field. > 'eventStatus' is meant to be the coarse version ok. - Mohammad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9602/#review18570 ----------------------------------------------------------- On April 3, 2013, 3:35 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9602/ > ----------------------------------------------------------- > > (Updated April 3, 2013, 3:35 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1209 > WIP patch > > > This addresses bug OOZIE-1209. > https://issues.apache.org/jira/browse/OOZIE-1209 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1463328 > trunk/client/src/main/java/org/apache/oozie/client/event/Event.java > PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java > PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1463328 > > trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java > 1463328 > trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1463328 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1463328 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1463328 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java > 1463328 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1463328 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java > 1463328 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1463328 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1463328 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1463328 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1463328 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java > 1463328 > trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java > 1463328 > trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java > 1463328 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1463328 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1463328 > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > 1463328 > trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java > 1463328 > > trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java > PRE-CREATION > trunk/core/src/main/resources/oozie-default.xml 1463328 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java > 1463328 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/9602/diff/ > > > Testing > ------- > > unit tests added > > > Thanks, > > Mona Chitnis > >
