----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9602/ -----------------------------------------------------------
(Updated April 9, 2013, 8:17 a.m.) Review request for oozie. Changes ------- Final patch for Mohammad's and Virag's comments. Mohammad, I addressed your final question by resorting to my earlier approach of a static method isEventsConfigured in the Event Service class itself Also, added 2 more tests to check more event attributes thoroughly Description ------- https://issues.apache.org/jira/browse/OOZIE-1209 WIP patch This addresses bug OOZIE-1209. https://issues.apache.org/jira/browse/OOZIE-1209 Diffs (updated) ----- trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1465918 trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1465918 trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1465918 trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1465918 trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1465918 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1465918 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1465918 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1465918 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1465918 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1465918 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1465918 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1465918 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1465918 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1465918 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1465918 trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1465918 trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1465918 trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1465918 trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1465918 trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1465918 trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java 1465918 trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1465918 trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java 1465918 trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java 1465918 trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1465918 trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION trunk/core/src/main/resources/oozie-default.xml 1465918 trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1465918 trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION Diff: https://reviews.apache.org/r/9602/diff/ Testing ------- unit tests added Thanks, Mona Chitnis
