> On April 5, 2013, 8:35 a.m., Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java, > > line 68 > > <https://reviews.apache.org/r/9602/diff/12/?file=278132#file278132line68> > > > > Is this for "TIMEOUT" state? If not, for all other states, missing > > dependency is not needed, right? > >
also sending event for WAITING state, when there is change in the missing dependencies. so need this for 2 types of events > On April 5, 2013, 8:35 a.m., Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java, line 48 > > <https://reviews.apache.org/r/9602/diff/12/?file=278138#file278138line48> > > > > there are 3 statuses of type Status, jobStatus, eventStatus. > > The method set which status. I think it is eventStatus. In that case, > > the method name could be better "setEventStatus". > > Is this an override method? if yes, please use "@override" > > It sets the actual job status first, and eventStatus as an addition. But fixed the variable above it to be named 'status' and not jobStatus <- typo. > On April 5, 2013, 8:35 a.m., Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java, > > line 58 > > <https://reviews.apache.org/r/9602/diff/12/?file=278140#file278140line58> > > > > there is another status called "PREP_SUSPEND" > > Do we need to do anything? yes that is similar to SUSPEND in behavior. adding it too. thanks! - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9602/#review18694 ----------------------------------------------------------- On April 5, 2013, 12:20 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9602/ > ----------------------------------------------------------- > > (Updated April 5, 2013, 12:20 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1209 > WIP patch > > > This addresses bug OOZIE-1209. > https://issues.apache.org/jira/browse/OOZIE-1209 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1464795 > trunk/client/src/main/java/org/apache/oozie/client/event/Event.java > PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java > PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1464795 > > trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java > 1464795 > trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java > 1464795 > trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java > 1464795 > trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java > 1464795 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1464795 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1464795 > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > 1464795 > trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java > PRE-CREATION > trunk/core/src/main/resources/oozie-default.xml 1464795 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java > 1464795 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/9602/diff/ > > > Testing > ------- > > unit tests added > > > Thanks, > > Mona Chitnis > >
